Skip to content

Commit a2e9202

Browse files
committed
Scripts: refresh all indices
Previously when trying to refresh indices, scripts would call $self->index->refresh. This would refresh the "currently used" index. That doesn't make any sense when splitting each type into its own index. This was also using ElasticSearchX::Model, which we want to get rid of. Instead, call ->indices->refresh via the Search::Elasticsearch object. This will refresh all indices, which is fine for our purposes. In the future, we could consider being more selective about which indices we are refreshing, but this is no worse than the old behavior.
1 parent f9f7dea commit a2e9202

File tree

10 files changed

+12
-12
lines changed

10 files changed

+12
-12
lines changed

lib/MetaCPAN/Script/Author.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ sub run {
4545
# ) unless $index =~ /author/;
4646

4747
$self->index_authors;
48-
$self->index->refresh;
48+
$self->es->indices->refresh;
4949
}
5050

5151
my @author_config_fields = qw(
@@ -167,7 +167,7 @@ sub index_authors {
167167
}
168168

169169
$bulk->flush;
170-
$self->index->refresh;
170+
$self->es->indices->refresh;
171171

172172
$self->perform_purges;
173173

lib/MetaCPAN/Script/CPANTesters.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ sub _build_db {
6565
sub run {
6666
my $self = shift;
6767
$self->index_reports;
68-
$self->index->refresh;
68+
$self->es->indices->refresh;
6969
}
7070

7171
sub index_reports {

lib/MetaCPAN/Script/CPANTestersAPI.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ has _bulk => (
4545
sub run {
4646
my $self = shift;
4747
$self->index_reports;
48-
$self->index->refresh;
48+
$self->es->indices->refresh;
4949
}
5050

5151
sub index_reports {

lib/MetaCPAN/Script/Favorite.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ sub run {
7070
}
7171

7272
$self->index_favorites;
73-
$self->index->refresh;
73+
$self->es->indices->refresh;
7474
}
7575

7676
sub index_favorites {

lib/MetaCPAN/Script/Latest.pm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ sub run {
6363
}
6464

6565
my $p = $self->packages;
66-
$self->index->refresh;
66+
$self->es->indices->refresh;
6767

6868
# If a distribution name is passed get all the package names
6969
# from 02packages that match that distribution so we can limit
@@ -251,7 +251,7 @@ sub run {
251251
$self->reindex( $bulk, $file_data, 'cpan' );
252252
}
253253
$bulk->flush;
254-
$self->index->refresh;
254+
$self->es->indices->refresh;
255255

256256
# Call Fastly to purge
257257
$self->purge_cpan_distnameinfos( [

lib/MetaCPAN/Script/Mirrors.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ with 'MetaCPAN::Role::Script', 'MooseX::Getopt';
1212
sub run {
1313
my $self = shift;
1414
$self->index_mirrors;
15-
$self->index->refresh;
15+
$self->es->indices->refresh;
1616
}
1717

1818
sub index_mirrors {

lib/MetaCPAN/Script/Package.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ has clean_up => (
2525
sub run {
2626
my $self = shift;
2727
$self->index_packages;
28-
$self->index->refresh;
28+
$self->es->indices->refresh;
2929
}
3030

3131
sub _get_02packages_fh {

lib/MetaCPAN/Script/Permission.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ has clean_up => (
2525
sub run {
2626
my $self = shift;
2727
$self->index_permissions;
28-
$self->index->refresh;
28+
$self->es->indices->refresh;
2929
}
3030

3131
sub index_permissions {

lib/MetaCPAN/Script/Purge.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ sub run {
135135
}
136136
}
137137

138-
$self->index->refresh;
138+
$self->es->indices->refresh;
139139
}
140140

141141
sub purge_author_releases {

lib/MetaCPAN/Script/Release.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ sub run {
254254
};
255255
}
256256
}
257-
$self->index->refresh unless $self->queue;
257+
$self->es->indices->refresh unless $self->queue;
258258

259259
# Call Fastly to purge
260260
$self->purge_cpan_distnameinfos( \@module_to_purge_dists );

0 commit comments

Comments
 (0)