Skip to content

Commit 5e9831b

Browse files
committed
release model does not need logger
1 parent 45f88ce commit 5e9831b

File tree

5 files changed

+5
-23
lines changed

5 files changed

+5
-23
lines changed

lib/MetaCPAN/Model/Release.pm

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ use Parse::PMFile ();
2020
use Path::Tiny qw( path );
2121
use Try::Tiny qw( catch try );
2222

23-
with 'MetaCPAN::Role::Logger';
24-
2523
has archive => (
2624
is => 'ro',
2725
isa => 'MetaCPAN::Model::Archive',

lib/MetaCPAN/Script/Release.pm

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,6 @@ sub _get_release_model {
270270
distinfo => $d,
271271
file => $archive_path,
272272
model => $self->model,
273-
level => $self->level,
274-
logger => $self->logger,
275273
status => $self->detect_status( $d->cpanid, $d->filename ),
276274
);
277275

t/model/release.t

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,8 @@ my $archive_file = File::Temp->new;
1717
getstore $url, $archive_file->filename;
1818
ok -s $archive_file->filename;
1919

20-
my $release = MetaCPAN::Model::Release->new(
21-
logger => $config->{logger},
22-
level => $config->{level},
23-
file => $archive_file->filename,
24-
);
25-
$release->set_logger_once;
20+
my $release
21+
= MetaCPAN::Model::Release->new( file => $archive_file->filename );
2622

2723
is $release->file, $archive_file->filename;
2824

t/model/release/dependencies.t

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,7 @@ subtest 'basic dependencies' => sub {
1414
= fakecpan_dir->child(
1515
'/authors/id/M/MS/MSCHWERN/Prereqs-Basic-0.01.tar.gz');
1616

17-
my $release = MetaCPAN::Model::Release->new(
18-
logger => $config->{logger},
19-
level => $config->{level},
20-
file => $file,
21-
);
22-
$release->set_logger_once;
17+
my $release = MetaCPAN::Model::Release->new( file => $file );
2318

2419
my $dependencies = $release->dependencies;
2520

t/model/release/metadata.t

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,8 @@ foreach my $test (
2323
die 'You need to build your fakepan (with t/fakepan.t) first'
2424
unless -e $path;
2525

26-
my $release = MetaCPAN::Model::Release->new(
27-
logger => $config->{logger},
28-
level => $config->{level},
29-
file => $path
30-
);
31-
$release->set_logger_once;
32-
my $meta = $release->metadata;
26+
my $release = MetaCPAN::Model::Release->new( file => $path );
27+
my $meta = $release->metadata;
3328

3429
# some way to identify which file the meta came from
3530
like eval { $meta->generated_by }, qr/^$genby/,

0 commit comments

Comments
 (0)