You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix installing rsync by specifying a minimum rather than exact version
hadolint complains about installing apt packages without specifying a
version. For rsync, this is exceedingly unlikely to be a problem, but
still in spirit it makes sense to be more explicit. Specifying the
version explicitly has caused problems several times because our base
image has changed, and the given versions are no longer available.
Instead of specifying an exact package, we can use apt-get satisfy,
which accepts a version string that can specify a minimum version.
I'm not sure if hadolint understands apt-get satisfy, but this stops it
from complaining. And it already wasn't complaining about not specifying
jq's version.
Also move the ignore rule about using a latest tag to an inline comment
rather than in a separate file. This means it explicitly only covers the
metacpan-base image, rather than any other image that could be in the
file. Currently, there aren't any targets, but they could be added in
the future and if they are using images that we don't control, we
shouldn't be using latest.
0 commit comments