always use DateTime::Format::ISO8601 for parsing dates from API

We're already using DateTime::Format::ISO8601 to parse dates in some
cases, so just use it consistently, removing the need for
Regexp::Common::time.

Author: haarg

cpanfile

@@ -70,8 +70,6 @@ requires 'Plack::Middleware::Session::Cookie';
 requires 'Plack::Session';
 requires 'Plack::Test';
 requires 'Ref::Util', '>= 0.008';
-requires 'Regexp::Common';
-requires 'Regexp::Common::time';
 requires 'Starman', '>= 0.4008';
 requires 'Template::Alloy', '== 1.020';
 requires 'Term::Size::Any';

cpanfile.snapshot

@@ -2740,20 +2740,6 @@ DISTRIBUTIONS
       perl 5.008001
       strict 0
       warnings 0
-  Modern-Perl-1.20200211
-    pathname: C/CH/CHROMATIC/Modern-Perl-1.20200211.tar.gz
-    provides:
-      Modern::Perl 1.20200211
-      odern::Perl 1.20200211
-    requirements:
-      ExtUtils::MakeMaker 0
-      IO::File 0
-      IO::Handle 0
-      feature 0
-      mro 0
-      perl 5.010
-      strict 0
-      warnings 0
   Module-Build-0.4231
     pathname: L/LE/LEONT/Module-Build-0.4231.tar.gz
     provides:
@@ -4853,60 +4839,6 @@ DISTRIBUTIONS
       ExtUtils::MakeMaker 0
       XSLoader 0
       perl 5.006
-  Regexp-Common-2017060201
-    pathname: A/AB/ABIGAIL/Regexp-Common-2017060201.tar.gz
-    provides:
-      Regexp::Common 2017060201
-      Regexp::Common::CC 2017060201
-      Regexp::Common::Entry 2017060201
-      Regexp::Common::SEN 2017060201
-      Regexp::Common::URI 2017060201
-      Regexp::Common::URI::RFC1035 2017060201
-      Regexp::Common::URI::RFC1738 2017060201
-      Regexp::Common::URI::RFC1808 2017060201
-      Regexp::Common::URI::RFC2384 2017060201
-      Regexp::Common::URI::RFC2396 2017060201
-      Regexp::Common::URI::RFC2806 2017060201
-      Regexp::Common::URI::fax 2017060201
-      Regexp::Common::URI::file 2017060201
-      Regexp::Common::URI::ftp 2017060201
-      Regexp::Common::URI::gopher 2017060201
-      Regexp::Common::URI::http 2017060201
-      Regexp::Common::URI::news 2017060201
-      Regexp::Common::URI::pop 2017060201
-      Regexp::Common::URI::prospero 2017060201
-      Regexp::Common::URI::tel 2017060201
-      Regexp::Common::URI::telnet 2017060201
-      Regexp::Common::URI::tv 2017060201
-      Regexp::Common::URI::wais 2017060201
-      Regexp::Common::_support 2017060201
-      Regexp::Common::balanced 2017060201
-      Regexp::Common::comment 2017060201
-      Regexp::Common::delimited 2017060201
-      Regexp::Common::lingua 2017060201
-      Regexp::Common::list 2017060201
-      Regexp::Common::net 2017060201
-      Regexp::Common::number 2017060201
-      Regexp::Common::profanity 2017060201
-      Regexp::Common::whitespace 2017060201
-      Regexp::Common::zip 2017060201
-    requirements:
-      Config 0
-      ExtUtils::MakeMaker 0
-      perl 5.01
-      strict 0
-      vars 0
-      warnings 0
-  Regexp-Common-time-0.16
-    pathname: M/MA/MANWAR/Regexp-Common-time-0.16.tar.gz
-    provides:
-      Regexp::Common::time 0.16
-    requirements:
-      ExtUtils::MakeMaker 0
-      Modern::Perl 0
-      Regexp::Common 0
-      Test::More 0.40
-      perl 5.006
   Role-Tiny-2.002004
     pathname: H/HA/HAARG/Role-Tiny-2.002004.tar.gz
     provides:

lib/MetaCPAN/Web/Role/Response.pm

@@ -2,7 +2,7 @@ package MetaCPAN::Web::Role::Response;
 
 use Moose::Role;
 use DateTime::Format::HTTP;
-use Regexp::Common qw(time);
+use DateTime::Format::ISO8601 ();
 
 =head2 last_modified
 
@@ -14,20 +14,15 @@ an ISO8601 formatted date string.
 
 sub last_modified {
     my ( $self, $date ) = @_;
-    if ( $date =~ /^\d+$/ ) {
+    if ( ref $date ) {
+
+        # assume it's a DateTime
+    }
+    elsif ( $date =~ /^\d+$/ ) {
         $date = DateTime->from_epoch( epoch => $date );
     }
-    elsif ( $date =~ /$RE{time}{iso}{-keep}/ ) {
-        $date = eval {
-            DateTime->new(
-                year   => $2,
-                month  => $3,
-                day    => $4,
-                hour   => $5,
-                minute => $6,
-                second => $7,
-            );
-        };
+    else {
+        $date = DateTime::Format::ISO8601->parse_datetime($date);
     }
     return unless ( eval { $date->isa('DateTime') } );
     $self->header(

lib/MetaCPAN/Web/View/HTML.pm

@@ -11,7 +11,6 @@ use List::Util       ();
 use Cpanel::JSON::XS ();
 use Gravatar::URL    ();
 use MetaCPAN::Web::RenderUtil qw( filter_html );
-use Regexp::Common qw(time);
 use Number::Format      ();
 use Text::MultiMarkdown ();
 use Text::Pluralize     ();