Enable all compiler warnings and solve them (GCC, Clang, MSVC)

[viferga]

🚀 Feature

In our compiler infrastructure we already enable many warnings but it will be interesting to enable all of them and solve them. Many are pretty easy to solve like -Wshadow, which is solved by changing the name of a variable for example.

core/cmake/Warnings.cmake

Line 49 in cb8429f

# TODO: Uncomment the rest of the warnings, enable Weverything for clang

core/cmake/Warnings.cmake

Line 80 in cb8429f

# C only flags

core/cmake/Warnings.cmake

Line 89 in cb8429f

set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W4") # /Wall

core/cmake/Warnings.cmake

Line 109 in cb8429f

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4") # /Wall

This would improve the code quality, eventually if all of them are solved, we can also enable -Werror so any warning is treated as error and we improve the code quality.