SEARCH-666: Use quality names rather than numeric IDs

This matches what we do elsewhere in the API, matches what was listed
in our documentation, and removes the split between -1 (default)
and 1 (normal) which we don't generally expose to data users.

Author: reosarevok

sir/schema/__init__.py

@@ -399,7 +399,7 @@
     F("mediums", "medium_count", transformfunc=tfs.integer_sum, trigger=False),
     F("packaging", "packaging.name"),
     F("primarytype", "release_group.type.name"),
-    F("quality", "quality"),
+    F("quality", "quality", transformfunc=tfs.quality_to_string),
     F("rgid", "release_group.gid"),
     F("script", "script.iso_code"),
     F("secondarytype", "release_group.secondary_types.secondary_type.name"),

sir/schema/transformfuncs.py

@@ -101,6 +101,17 @@ def boolean(values):
     else:
         return "f"
 
+def quality_to_string(quality):
+    """
+    :type quality: int
+    """
+    if quality == 0:
+        return "low"
+    elif quality == 2:
+        return "high"
+    else:
+        # Both 1 (normal, hand-set) and -1 (default) should return "normal"
+        return "normal"
 
 def url_type(values):
     types = set(URL_LINK_TABLE_TO_ENTITYTYPE[value] for value in values)

test/sql/release.sql

@@ -53,7 +53,7 @@ INSERT INTO track (id, gid, name, artist_credit, medium, position, number, recor
 
 INSERT INTO release_group (id, gid, name, artist_credit)
     VALUES (4, '329fb554-2a81-3d8a-8e22-ec2c66810019', 'Blonde on Blonde', 2);
-INSERT INTO release (id, gid, name, artist_credit, release_group) VALUES (5, '538aff00-a009-4515-a064-11a6d5a502ee', 'Blonde on Blonde', 2, 4);
+INSERT INTO release (id, gid, name, artist_credit, release_group, quality) VALUES (5, '538aff00-a009-4515-a064-11a6d5a502ee', 'Blonde on Blonde', 2, 4, 0);
 ;
 
 -- release_meta

test/test_indexing_real_data.py

@@ -402,7 +402,7 @@ def test_index_release(self):
                 'mbid': '7a906020-72db-11de-8a39-0800200c9a66',
                 'rgid': '3b4faa80-72d9-11de-8a39-0800200c9a66',
                 'release': u'Release #2',
-                'quality': -1
+                'quality': u'normal'
             },
             {
                 'comment': u'Comment',
@@ -424,7 +424,7 @@ def test_index_release(self):
                 'rgid': '3b4faa80-72d9-11de-8a39-0800200c9a66',
                 'laid': '00a23bd0-72db-11de-8a39-0800200c9a66',
                 'release': u'Arrival',
-                'quality': -1,
+                'quality': u'normal',
                 'primarytype': u'Album'
             },
             {
@@ -436,7 +436,7 @@ def test_index_release(self):
                 'mbid': '538aff00-a009-4515-a064-11a6d5a502ee',
                 'rgid': '329fb554-2a81-3d8a-8e22-ec2c66810019',
                 'release': u'Blonde on Blonde',
-                'quality': -1},
+                'quality': u'low'},
             {
                 '_store': '<ns0:release xmlns:ns0="http://musicbrainz.org/ns/mmd-2.0#" id="25b6fe30-ff5b-11de-8a39-0800200c9a66"><ns0:title>Various Release</ns0:title><ns0:artist-credit><ns0:name-credit><ns0:name>Various Artists</ns0:name><ns0:artist id="7a906020-72db-11de-8a39-0800200c9a66"><ns0:name>Various Artists</ns0:name><ns0:sort-name>Various Artists</ns0:sort-name></ns0:artist></ns0:name-credit></ns0:artist-credit><ns0:release-group id="25b6fe30-ff5b-11de-8a39-0800200c9a66"><ns0:title>Various Release</ns0:title></ns0:release-group><ns0:medium-list count="1"><ns0:track-count>3</ns0:track-count><ns0:medium><ns0:disc-list count="0" /><ns0:track-list count="3" /></ns0:medium></ns0:medium-list><ns0:tag-list /></ns0:release>',
                 'tracks': 3, 'artist': u'Various Artists',
@@ -448,7 +448,7 @@ def test_index_release(self):
                 'rgid': '25b6fe30-ff5b-11de-8a39-0800200c9a66',
                 'release': u'Various Release',
                 'mediums': 1,
-                'quality': -1
+                'quality': u'normal'
             }
         ]
         self._test_index_entity("release", expected)