-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add support for SeeedStudio's XIAO ESP32-S3 Wio-SX1262 Header #8448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest removing the ASCII artwork. It's cute when the OEM does it. It's annoying if it's everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Also changed to -D PRIVATE_HW
Compiled with ~/.platformio/penv/bin/pio run -e seeed-xiao-s3-diy-header which created ~/Desktop/mestastic_firmware/.pio/build/seeed-xiao-s3-diy-header/firmware.factory.bin
Flashed with: ~/.platformio/penv/bin/pio run -e seeed-xiao-s3-diy-header -t upload
and tested. Also tried it with Visual Studio Code to build and flash as well, just in case.
|
This looks good, and it's good that you've tested it. Putting it in DIY as a separate variant is the right thing to do. @fifieldt does this need to be private_hw or continue under the HWID for the xiao S3? |
Remove ASCII art
|
any updates? |
|
You will need to update the GPS pin definitions in line with #8772 Also, you have overlapping I2C pin definitions with the radio pins. I suggest omitting them, or pushing them to unused internal pins, or putting them on the BTB header. |
Fixed: #8409
🤝 Attestations