Skip to content

Add a bot to comment the LightHouse report for our convenience in each PR #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aakankshabhende opened this issue Dec 16, 2024 · 7 comments
Labels
area/website issue/stale Issue has not had any activity for an extended period of time kind/enhancement New feature or request

Comments

@aakankshabhende
Copy link
Member

Current Behavior

We currently don't have a LightHouse CI workflow which will check for Performance, Accessibility, Best practices, SEO, PWA for each PR and we manually need to go to the deployment and check it.

Desired Behavior

We should have a bot which will comment the LightHouse report for our convenience in each PR.

Workflow action: https://github.com/treosh/lighthouse-ci-action

@aakankshabhende
Copy link
Member Author

@leecalcote @vishalvivekm Could you please share your opinion on this?
I would love to work on this!

@aakankshabhende
Copy link
Member Author

As I'm working on improving the accessibility of the site, I believe having this bot will help us to maintain score for the future MRs.

@vishalvivekm
Copy link
Contributor

@aakankshabhende let's discuss this in websites call.

@leecalcote
Copy link
Member

@aakankshabhende, I think this is generally a positive thing, particularly when it comes to the Catalog pages. With this said, of the effort that we're going to incorporating lighthouse in this repo, there are a couple of higher priority areas in need of help where your efforts will be both better supported and more impactful.

  1. The meshery.io/catalog offers no way to filter catalog content by content type: design pattern versus wasm filter versus meshery model. @vishalvivekm has been unable to implement this. Perhaps, you can.
  2. The list of relationships in Meshery UI's Settings page is missing details that users need in order to find that UI helpful. I have sent details in Slack on this subject.

@leecalcote
Copy link
Member

Related issue - #973

Copy link

stale bot commented Jan 15, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Jan 15, 2025
Copy link

stale bot commented Jan 24, 2025

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/stale Issue has not had any activity for an extended period of time kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants