Add Laplacian smooth for monitor function #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
requested changes
Feb 29, 2024
Member
jwallwork23
left a comment
jwallwork23
left a comment
There was a problem hiding this comment.
A first request: please add tests for this new functionality. The existing test suite needs some work but we should make sure any new functionality is covered by tests.
Thinking about it, what you're doing here seems to be very similar to what's done in LaplacianSmoother. Do you think you could piggy-back off that existing implementation or even merge them? Also, it is not a good idea for us to have two different things with such similar names and functionalities.
Collaborator
Author
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6
Add Laplacian smooth for monitor function.