Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resourcet-1.3 in broadcast-chan-conduit #20

Open
jchia opened this issue Feb 3, 2024 · 2 comments
Open

Allow resourcet-1.3 in broadcast-chan-conduit #20

jchia opened this issue Feb 3, 2024 · 2 comments

Comments

@jchia
Copy link

jchia commented Feb 3, 2024

There is a breaking change in resourcet-1.3 related to Data.Acquire.ReleaseType where ReleaseException is replaced by ReleaseExceptionWith.

This affects BroadcastChan.Conduit.Internal, which uses ReleaseException, including for constructing a BroadcastChan.Extra.ThreadBracket wherein cleanupForkError does not get the exception to use for ReleaseExceptionWith value construction. Thus, the changes necessary for using resourcet-1.3 are non-trivial and require code changes and not just .cabal changes, and perhaps even BroadcastChan.Extra.ThreadBracket needs to change.

@merijn
Copy link
Owner

merijn commented Feb 5, 2024

Yeah, that's been a thorn in my side for a while. I was working on a fix at one point, but that got stuck and ended up on the low priority pile for awhile.

@jchia
Copy link
Author

jchia commented Feb 5, 2024

Have you decided what designs are acceptable, though? It seems that an interface change in ThreadBracket is inevitable in a new version of broadcast-extra that uses resourcet-1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants