Skip to content

Commit df831cb

Browse files
authored
[MOO-1995] feat: add ignoreSilentSwitch property to iOS component (#360)
2 parents 307c987 + b8cc87a commit df831cb

File tree

6 files changed

+18
-8
lines changed

6 files changed

+18
-8
lines changed

packages/pluggableWidgets/video-player-native/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
- We have updated `react-native-video` version to 6.10.2.
10+
- We have fixed an issue where videos were muted in iOS silent mode. The video player now plays sound even when the device is set to silent.
11+
912
## [6.3.0] - 2025-10-2
1013

1114
### Changed

packages/pluggableWidgets/video-player-native/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "video-player-native",
33
"widgetName": "VideoPlayer",
4-
"version": "6.3.0",
4+
"version": "6.3.1",
55
"license": "Apache-2.0",
66
"repository": {
77
"type": "git",
@@ -21,7 +21,7 @@
2121
"dependencies": {
2222
"@mendix/piw-native-utils-internal": "*",
2323
"react-native-vector-icons": "10.2.0",
24-
"react-native-video": "6.10.0"
24+
"react-native-video": "6.10.2"
2525
},
2626
"devDependencies": {
2727
"@mendix/piw-utils-internal": "1.0.0",

packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
164164
<Video
165165
{...videoProps}
166166
paused={!props.autoStart && !currentPlayTime}
167+
ignoreSilentSwitch="ignore"
167168
onLoad={data => {
168169
setStatus(StatusEnum.READY);
169170
setVideoAspectRatio(data.naturalSize.width / data.naturalSize.height);

packages/pluggableWidgets/video-player-native/src/__tests__/__snapshots__/VideoPlayer.spec.tsx.snap

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ exports[`VideoPlayer VideoPlayerAndroid render video with controls 1`] = `
5454
>
5555
<Video
5656
controls={true}
57+
ignoreSilentSwitch="ignore"
5758
muted={false}
5859
onError={[Function]}
5960
onLoad={[Function]}
@@ -198,6 +199,7 @@ exports[`VideoPlayer VideoPlayerAndroid render video without controls if showCon
198199
>
199200
<Video
200201
controls={false}
202+
ignoreSilentSwitch="ignore"
201203
muted={false}
202204
onError={[Function]}
203205
onLoad={[Function]}
@@ -277,6 +279,7 @@ exports[`VideoPlayer hides the loading indicator after load 1`] = `
277279
>
278280
<Video
279281
controls={true}
282+
ignoreSilentSwitch="ignore"
280283
muted={false}
281284
onError={[Function]}
282285
onLoad={[Function]}
@@ -420,6 +423,7 @@ exports[`VideoPlayer load a video and calculate the aspect ratio 1`] = `
420423
>
421424
<Video
422425
controls={true}
426+
ignoreSilentSwitch="ignore"
423427
muted={false}
424428
onError={[Function]}
425429
onLoad={[Function]}
@@ -566,6 +570,7 @@ exports[`VideoPlayer renders a loading indicator 1`] = `
566570
>
567571
<Video
568572
controls={true}
573+
ignoreSilentSwitch="ignore"
569574
muted={false}
570575
onError={[Function]}
571576
onLoad={[Function]}
@@ -714,6 +719,7 @@ exports[`VideoPlayer shows the loading indicator if the source changes 1`] = `
714719
>
715720
<Video
716721
controls={true}
722+
ignoreSilentSwitch="ignore"
717723
muted={false}
718724
onError={[Function]}
719725
onLoad={[Function]}

packages/pluggableWidgets/video-player-native/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="VideoPlayer" version="6.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="VideoPlayer" version="6.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="VideoPlayer.xml" />
66
</widgetFiles>

pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)