Skip to content

Commit ca91227

Browse files
authored
[MOO-1315]: Resolve issue with callout display on iOS (#168)
2 parents f8238f1 + 3562280 commit ca91227

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

packages/pluggableWidgets/maps-native/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We Resolved an issue where an empty marker callout box would appear in Apple Maps on iOS when no content was provided for the marker.
12+
913
## [4.0.0] - 2023-3-28
1014

1115
## BREAKING

packages/pluggableWidgets/maps-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "maps-native",
33
"widgetName": "Maps",
4-
"version": "4.0.0",
4+
"version": "4.0.1",
55
"license": "Apache-2.0",
66
"repository": {
77
"type": "git",

packages/pluggableWidgets/maps-native/src/Maps.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export class Maps extends Component<Props, State> {
7575
{this.state.status !== Status.LoadingMarkers ? (
7676
<MapView
7777
ref={this.mapViewRef}
78-
provider={this.props.provider === "default" ? null : this.props.provider}
78+
provider={this.props.provider === "default" ? undefined : this.props.provider}
7979
mapType={this.props.mapType}
8080
showsUserLocation={this.props.showsUserLocation}
8181
showsMyLocationButton={this.props.showsUserLocation}
@@ -111,8 +111,8 @@ export class Maps extends Component<Props, State> {
111111
<MarkerView
112112
key={key}
113113
coordinate={coordinate}
114-
title={this.props.interactive ? props.title : ""}
115-
description={this.props.interactive ? props.description : ""}
114+
title={this.props.interactive ? props.title : undefined}
115+
description={this.props.interactive ? props.description : undefined}
116116
onPress={this.props.interactive ? () => onMarkerPress(props.onClick) : undefined}
117117
pinColor={props.iconColor || this.styles.marker.color}
118118
opacity={this.styles.marker.opacity}

packages/pluggableWidgets/maps-native/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="Maps" version="4.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="Maps" version="4.0.1" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="Maps.xml" />
66
</widgetFiles>

packages/pluggableWidgets/maps-native/src/util/data.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export function convertStaticModeledMarker(marker: MarkersType): ModeledMarker {
99
address: marker.address?.value,
1010
latitude: Number(marker.latitude?.value),
1111
longitude: Number(marker.longitude?.value),
12-
title: marker.title?.value,
13-
description: marker.description?.value,
12+
title: marker.title?.value ? marker.title?.value : undefined,
13+
description: marker.description?.value ? marker.description?.value : undefined,
1414
onClick: marker.onClick,
1515
icon: marker.icon?.value,
1616
iconSize: Number(marker.iconSize),
@@ -42,8 +42,8 @@ function fromDatasource(marker: DynamicMarkersType, item: ObjectItem): ModeledMa
4242
address: locationDynamicType === "address" && address ? address.get(item).value : undefined,
4343
latitude: locationDynamicType === "latlng" && latitude ? Number(latitude.get(item).value) : undefined,
4444
longitude: locationDynamicType === "latlng" && longitude ? Number(longitude.get(item).value) : undefined,
45-
title: title ? title.get(item).value : "",
46-
description: description ? description.get(item).value : "",
45+
title: title ? title.get(item).value : undefined,
46+
description: description ? description.get(item).value : undefined,
4747
onClick: onClick ? onClick.get(item) : undefined,
4848
icon: icon ? icon.value : undefined,
4949
iconSize: iconSize ? Number(iconSize) : undefined,

0 commit comments

Comments
 (0)