Merge #565

565: Fix ignored paginationTotalHits r=bidoubiwa a=bidoubiwa

fixes: #562

Co-authored-by: Charlotte Vermandel <[email protected]>

Author: bors[bot]

src/client/instant-meilisearch-client.ts

@@ -31,11 +31,13 @@ export function instantMeiliSearch(
 ): InstantMeiliSearchInstance {
   // create search resolver with included cache
   const searchResolver = SearchResolver(SearchCache())
-
+  // paginationTotalHits can be 0 as it is a valid number
+  const paginationTotalHits =
+    options.paginationTotalHits != null ? options.paginationTotalHits : 200
   const context: Context = {
     primaryKey: options.primaryKey || undefined,
     placeholderSearch: options.placeholderSearch !== false, // true by default
-    paginationTotalHits: options.paginationTotalHits || 200,
+    paginationTotalHits,
   }
 
   return {

tests/pagination.tests.ts

@@ -1,3 +1,4 @@
+import { instantMeiliSearch } from '../src'
 import { searchClient, dataset, Movies } from './assets/utils'
 
 describe('Pagination browser test', () => {
@@ -97,4 +98,55 @@ describe('Pagination browser test', () => {
     expect(hits.length).toBe(0)
     expect(hits).toEqual([])
   })
+
+  test('Test pagination total hits ', async () => {
+    const customClient = instantMeiliSearch(
+      'http://localhost:7700',
+      'masterKey',
+      {
+        paginationTotalHits: 1,
+      }
+    )
+    const response = await customClient.search<Movies>([
+      {
+        indexName: 'movies',
+      },
+    ])
+    const hits = response.results[0].hits
+    expect(hits.length).toBe(1)
+  })
+
+  test('Test zero pagination total hits ', async () => {
+    const customClient = instantMeiliSearch(
+      'http://localhost:7700',
+      'masterKey',
+      {
+        paginationTotalHits: 0,
+      }
+    )
+    const response = await customClient.search<Movies>([
+      {
+        indexName: 'movies',
+      },
+    ])
+    const hits = response.results[0].hits
+    expect(hits.length).toBe(0)
+  })
+
+  test('Test bigger pagination total hits than nbr hits', async () => {
+    const customClient = instantMeiliSearch(
+      'http://localhost:7700',
+      'masterKey',
+      {
+        paginationTotalHits: 1000,
+      }
+    )
+    const response = await customClient.search<Movies>([
+      {
+        indexName: 'movies',
+      },
+    ])
+    const hits = response.results[0].hits
+    expect(hits.length).toBe(6)
+  })
 })