Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support JPEG-XL and AVIF #118

Closed
mshibanami opened this issue Oct 19, 2024 · 2 comments
Closed

[Feature Request] Support JPEG-XL and AVIF #118

mshibanami opened this issue Oct 19, 2024 · 2 comments

Comments

@mshibanami
Copy link

General Information

  • MEGA Version: 16.0.1
  • iOS Version(s): iOS 18.0.1
  • Devices/Simulators: iPhone 15
  • Reproducible? (Yes/No): Yes

What happened?

Currently, the iOS app doesn't recognize JPEG-XL (.jxl) and AVIF (.avif) files as images. Is there a chance to add support for them? I believe that at least JPEG-XL makes sense to support since it's now supported by the iPhone 16 Pro.

FWIW, this is my personal implementation: https://github.com/mshibanami/meganz-iOS/commit/0836fdc38f76413f13f826877bc58bdc399c3197

I confirmed that it works fine for me. (= UIImageView already supports both formats.)

(I won't create a pull request since the team always seems to prefer making changes internally, and I accidentally included an unnecessary change.)

What did you expect to happen?

Image files with .jxl or .avif extensions should be recognized as images, and I should be able to preview them with horizontal swipes.

Misc.

IIRC, my changes are not enough as they don't organize the items in the Recents section properly. Also, these formats aren't recognized on the Web either. Therefore, I think changes will be needed for https://github.com/meganz/sdk as well.


Thank you for maintaining this great service!

@mshibanami mshibanami changed the title [Feature Request] Support JSX and AVIF [Feature Request] Support JPEG-XL and AVIF Oct 20, 2024
@jnavarrom
Copy link
Member

Hello,

Both images type are now supported in versions 16.2+

Thanks for reporting

@mshibanami
Copy link
Author

Perfect. It works for me now. Thank you for the quick work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants