Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary use of roles in aria basics article #37526

Open
scottaohara opened this issue Jan 6, 2025 · 0 comments
Open

Unnecessary use of roles in aria basics article #37526

scottaohara opened this issue Jan 6, 2025 · 0 comments
Labels
Content:Learn:Accessibility Accessibility documentation in the Learn Area help wanted If you know something about this topic, we would love your help!

Comments

@scottaohara
Copy link
Contributor

scottaohara commented Jan 6, 2025

MDN URL

https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/Accessibility/WAI-ARIA_basics

What specific section or headline is this issue about?

Signposts/Landmarks

What information was incorrect, unhelpful, or incomplete?

this section / example should be rethought. per my other comments, there's actually very little that was improved here - since aside from the search role, all other roles added were redundant.

it is also sending a confusing message, because the header, footer and main elements did not have roles added to them - so is this trying to imply that the elements that had the roles added somehow lacked support? or were the redundant roles not added to these elements because they were forgotten?

What did you expect to see?

if redundant roles were to be added, i'd expect them to be added to all elements with a note specifically stating this was done to support legacy browsers (Internet explorer) but that no modern browser needs any of these roles to be added.

OR, the inaccessible demo should instead just use divs with IDs that match the landmark names - and then put roles onto those div elements instead - so that the whole section doesn't need to be rewritten.

ideally, this would also mention that the search element exists and that could be used in tandem with the form element (or instead of it if this was a JS powered search).

a better job identifying that all the mentioned elements have implicit roles so developers don't need to explicitly add them could be another way to handle this / provide a separate demo (if my other suggestion to make all the elements divs for the initial example was used) to show that HTML is all that's needed here.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

originally noticed these issues when reviewing / commenting on - #37520

MDN metadata

Page report details
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 6, 2025
@Josh-Cena Josh-Cena added help wanted If you know something about this topic, we would love your help! Content:Learn:Accessibility Accessibility documentation in the Learn Area and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Learn:Accessibility Accessibility documentation in the Learn Area help wanted If you know something about this topic, we would love your help!
Projects
None yet
Development

No branches or pull requests

2 participants