diff --git a/ReactAndroid/src/androidTest/java/com/facebook/react/tests/TestIdTestCase.java b/ReactAndroid/src/androidTest/java/com/facebook/react/tests/TestIdTestCase.java
index 527e355c0e4a0c..90ac857c2827f5 100644
--- a/ReactAndroid/src/androidTest/java/com/facebook/react/tests/TestIdTestCase.java
+++ b/ReactAndroid/src/androidTest/java/com/facebook/react/tests/TestIdTestCase.java
@@ -46,8 +46,9 @@ protected String getReactApplicationKeyUnderTest() {
"Toolbar",
"TextInput",
"View",
- "WebView",
- "ScrollView Item (same id used for all items)");
+ // "WebView", TODO t11449130
+ "ScrollView Item (same id used for all items)"
+ );
public void testPropertyIsSetForViews() {
for (String tag : viewTags) {
diff --git a/ReactAndroid/src/androidTest/js/TestIdTestModule.js b/ReactAndroid/src/androidTest/js/TestIdTestModule.js
index 8ad181d0925c73..6f11c1574fab20 100644
--- a/ReactAndroid/src/androidTest/js/TestIdTestModule.js
+++ b/ReactAndroid/src/androidTest/js/TestIdTestModule.js
@@ -111,12 +111,16 @@ var TestIdTestApp = React.createClass({
- }
style={styles.base}
- />
+ />*/}
);
diff --git a/circle.yml b/circle.yml
index 8717c9f4139ff6..136d49b3ae218e 100644
--- a/circle.yml
+++ b/circle.yml
@@ -47,6 +47,7 @@ test:
- source scripts/circle-ci-android-setup.sh && waitForAVD
override:
+ # TODO flow is disabled see t11343811 and 0.25.1
# eslint bot
# - cat <(echo eslint; npm run lint --silent -- --format=json; echo flow; npm run flow --silent -- check --json) | GITHUB_TOKEN="af6ef0d15709bc91d""06a6217a5a826a226fb57b7" CI_USER=$CIRCLE_PROJECT_USERNAME CI_REPO=$CIRCLE_PROJECT_REPONAME PULL_REQUEST_NUMBER=$CIRCLE_PR_NUMBER node bots/code-analysis-bot.js
# JS tests for dependencies installed with npm3
@@ -69,14 +70,14 @@ test:
# build test APK
- buck install ReactAndroid/src/androidTest/buck-runner:instrumentation-tests --config build.threads=1
# run installed apk with tests
- - node ./scripts/run-ci-android-instrumentation-tests.js --retries 3 --path ./ReactAndroid/src/androidTest/java/com/facebook/react/tests --package com.facebook.react.tests
+ - node ./scripts/run-android-ci-instrumentation-tests.js --retries 3 --path ./ReactAndroid/src/androidTest/java/com/facebook/react/tests --package com.facebook.react.tests
- ./gradlew :ReactAndroid:testDebugUnitTest
# Deprecated: these tests are executed using Buck above, while we support Gradle we just make sure the test code compiles
- ./gradlew :ReactAndroid:assembleDebugAndroidTest
# Android e2e test
- - node ./scripts/run-ci-e2e-tests.js --android --js --retries 5
+ - node ./scripts/run-ci-e2e-tests.js --android --js --retries 3
# testing docs generation is not broken
- cd website && node ./server/generate.js
diff --git a/scripts/run-ci-android-instrumentation-tests.js b/scripts/run-android-ci-instrumentation-tests.js
similarity index 90%
rename from scripts/run-ci-android-instrumentation-tests.js
rename to scripts/run-android-ci-instrumentation-tests.js
index 7bd04bb84f9c50..329d46070fa12b 100644
--- a/scripts/run-ci-android-instrumentation-tests.js
+++ b/scripts/run-android-ci-instrumentation-tests.js
@@ -42,8 +42,10 @@ let exitCode = 0;
testClasses.forEach((testClass) => {
if (tryExecNTimes(
() => {
+ echo(`Starting ${testClass}`);
+ // any faster means Circle CI crashes
exec('sleep 10s');
- return exec(`./scripts/run-android-instrumentation-tests.sh ${argv.package} ${testClass}`).code;
+ return exec(`./scripts/run-instrumentation-tests-via-adb-shell.sh ${argv.package} ${testClass}`).code;
},
numberOfRetries)) {
echo(`${testClass} failed ${numberOfRetries} times`);
diff --git a/scripts/run-android-local-integration-test.sh b/scripts/run-android-local-integration-tests.sh
similarity index 100%
rename from scripts/run-android-local-integration-test.sh
rename to scripts/run-android-local-integration-tests.sh
diff --git a/scripts/run-android-instrumentation-tests.sh b/scripts/run-instrumentation-tests-via-adb-shell.sh
similarity index 100%
rename from scripts/run-android-instrumentation-tests.sh
rename to scripts/run-instrumentation-tests-via-adb-shell.sh