Skip to content

Commit 6e04177

Browse files
committed
turned on strictNullChecks for logconsole pkg; added it to docs build
1 parent 4b37b49 commit 6e04177

File tree

6 files changed

+7
-19
lines changed

6 files changed

+7
-19
lines changed

packages/logconsole-extension/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
"extends": "../../tsconfigbase",
33
"compilerOptions": {
44
"outDir": "lib",
5-
"rootDir": "src",
6-
"strictNullChecks": false
5+
"rootDir": "src"
76
},
87
"include": ["src/*"],
98
"references": [

packages/logconsole/src/widget.ts

+3-6
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,6 @@ class LogConsoleOutputPrompt extends Widget implements IOutputPrompt {
8888
* with prompts showing log timestamps.
8989
*/
9090
class LogConsoleOutputArea extends OutputArea {
91-
/**
92-
* The rendermime instance used by the widget.
93-
*/
94-
rendermime: IRenderMimeRegistry | null;
9591
/**
9692
* Output area model used by the widget.
9793
*/
@@ -358,7 +354,8 @@ export class LogConsolePanel extends StackedPanel {
358354
const outputArea = this._outputAreas.get(viewId);
359355
if (outputArea) {
360356
if (change.newValue) {
361-
outputArea.rendermime = change.newValue;
357+
// cast away readonly
358+
(outputArea.rendermime as IRenderMimeRegistry) = change.newValue;
362359
} else {
363360
outputArea.dispose();
364361
}
@@ -420,7 +417,7 @@ export class LogConsolePanel extends StackedPanel {
420417
// add view for logger if not exist
421418
if (!this._outputAreas.has(viewId)) {
422419
const outputArea = new LogConsoleOutputArea({
423-
rendermime: logger.rendermime,
420+
rendermime: logger.rendermime!,
424421
contentFactory: new LogConsoleContentFactory(),
425422
model: logger.outputAreaModel
426423
});

packages/logconsole/tsconfig.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
"extends": "../../tsconfigbase",
33
"compilerOptions": {
44
"outDir": "lib",
5-
"rootDir": "src",
6-
"strictNullChecks": false
5+
"rootDir": "src"
76
},
87
"include": ["src/*"],
98
"references": [

packages/logconsole/tsconfig.test.json

-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
{
22
"extends": "../../tsconfigbase.test",
3-
"compilerOptions": {
4-
"strictNullChecks": false
5-
},
63
"include": ["src/*", "test/*"],
74
"references": [
85
{

packages/ui-components/.storybook/tsconfig.json

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"outDir": "dist",
88
"noImplicitReturns": true,
99
"noImplicitThis": true,
10-
"strictNullChecks": true,
1110
"skipLibCheck": true
1211
},
1312
"include": ["../src/**/*"],

typedoc.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,9 @@ module.exports = {
112112
'**/tests/**',
113113
'**/testutils/**',
114114

115-
'**/packages/celltags/**',
116-
'**/packages/logconsole/**'
115+
'**/packages/celltags/**'
116+
// '**/packages/logconsole/**'
117117
// '**/packages/settingregistry/**'
118-
119-
// '**/packages/celltags*/**',
120-
// '**/packages/logconsole*/**',
121118
],
122119
excludeNotExported: true,
123120
ignoreCompilerErrors: false,

0 commit comments

Comments
 (0)