Clean up package integrity (jupyterlab#10122)

Author: jtpio

buildutils/package.json

@@ -47,6 +47,7 @@
     "fs-extra": "^9.0.1",
     "glob": "~7.1.6",
     "inquirer": "^7.0.0",
+    "minimatch": "~3.0.4",
     "package-json": "^6.5.0",
     "prettier": "^2.1.1",
     "semver": "^7.3.2",

buildutils/src/ensure-package.ts

@@ -5,6 +5,7 @@
 
 import * as fs from 'fs-extra';
 import * as glob from 'glob';
+import * as minimatch from 'minimatch';
 import * as path from 'path';
 import * as prettier from 'prettier';
 import * as ts from 'typescript';
@@ -438,6 +439,58 @@ export async function ensurePackage(
     }
   }
 
+  // Ensure style and lib are included in files metadata.
+  const filePatterns: string[] = data.files || [];
+
+  // Function to get all of the files in a directory, recursively.
+  function recurseDir(dirname: string, files: string[]) {
+    if (!fs.existsSync(dirname)) {
+      return files;
+    }
+    fs.readdirSync(dirname).forEach(fpath => {
+      const absolute = path.join(dirname, fpath);
+      if (fs.statSync(absolute).isDirectory())
+        return recurseDir(absolute, files);
+      else return files.push(absolute);
+    });
+    return files;
+  }
+
+  // Ensure style files are included by pattern.
+  const styleFiles = recurseDir(path.join(pkgPath, 'style'), []);
+  styleFiles.forEach(fpath => {
+    const basePath = fpath.slice(pkgPath.length + 1);
+    let found = false;
+    filePatterns.forEach(fpattern => {
+      if (minimatch.default(basePath, fpattern)) {
+        found = true;
+      }
+    });
+    if (!found) {
+      messages.push(`File ${basePath} not included in files`);
+    }
+  });
+
+  // Ensure source TS files are included in lib (.js, .js.map, .d.ts)
+  const srcFiles = recurseDir(path.join(pkgPath, 'src'), []);
+  srcFiles.forEach(fpath => {
+    const basePath = fpath.slice(pkgPath.length + 1).replace('src', 'lib');
+    ['.js', '.js.map', '.d.ts'].forEach(ending => {
+      let found = false;
+      const targetPattern = basePath
+        .replace('.tsx', ending)
+        .replace('.ts', ending);
+      filePatterns.forEach(fpattern => {
+        if (minimatch.default(targetPattern, fpattern)) {
+          found = true;
+        }
+      });
+      if (!found) {
+        messages.push(`File ${targetPattern} not included in files`);
+      }
+    });
+  });
+
   // Ensure dependencies and dev dependencies.
   data.dependencies = deps;
   data.devDependencies = devDeps;

packages/celltags-extension/package.json

@@ -28,7 +28,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.{d.ts,js}",
+    "lib/*.{d.ts,js,js.map}",
     "style/*.css",
     "style/index.js"
   ],

packages/celltags/package.json

@@ -28,7 +28,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.{d.ts,js}",
+    "lib/*.{d.ts,js,js.map}",
     "style/*.css",
     "static/*.svg",
     "style/index.js"

packages/javascript-extension/package.json

@@ -22,8 +22,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.d.ts",
-    "lib/*.js",
+    "lib/*.{d.ts,js,js.map}",
     "style/*"
   ],
   "scripts": {

packages/json-extension/package.json

@@ -22,8 +22,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.d.ts",
-    "lib/*.js",
+    "lib/*.{d.ts,js,js.map}",
     "style/*"
   ],
   "scripts": {

packages/services/examples/browser/package.json

@@ -2,6 +2,9 @@
   "name": "@jupyterlab/example-services-browser",
   "version": "3.1.0-alpha.5",
   "private": true,
+  "files": [
+    "lib/*.{d.ts,js,js.map}"
+  ],
   "scripts": {
     "build": "tsc && webpack",
     "clean": "rimraf lib && rimraf tsconfig.tsbuildinfo",

packages/ui-components-extension/package.json

@@ -22,8 +22,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.d.ts",
-    "lib/*.js",
+    "lib/*.{d.ts,js,js.map}",
     "style/*"
   ],
   "scripts": {

packages/vdom-extension/package.json

@@ -22,8 +22,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.d.ts",
-    "lib/*.js",
+    "lib/*.{d.ts,js,js.map}",
     "style/*"
   ],
   "scripts": {

packages/vdom/package.json

@@ -22,8 +22,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.d.ts",
-    "lib/*.js",
+    "lib/*.{d.ts,js,js.map}",
     "style/*"
   ],
   "scripts": {

packages/vega5-extension/package.json

@@ -22,8 +22,7 @@
     "lib": "lib/"
   },
   "files": [
-    "lib/*.d.ts",
-    "lib/*.js",
+    "lib/*.{d.ts,js,js.map}",
     "style/*.*"
   ],
   "scripts": {

typedoc.js

@@ -1,4 +1,4 @@
-// const git = require('git-rev-sync');
+const fs = require('fs');
 
 const packages = [
   // 'application-extension',
@@ -86,12 +86,11 @@ const packages = [
   'vega5-extension'
 ];
 
-const entryPoints = packages.flatMap(p => [
-  `packages/${p}/src/index.ts`,
-  `packages/${p}/src/index.tsx`
-  // `${__dirname}/packages/${p}/src/*.d.ts`,
-  // `${__dirname}/packages/${p}/src/index.ts`,
-]);
+const entryPoints = packages
+  .flatMap(p => [`packages/${p}/src/index.ts`, `packages/${p}/src/index.tsx`])
+  .filter(function (path) {
+    return fs.existsSync(path);
+  });
 
 const exclude =
   packages.flatMap(p => [`packages/${p}/test`]) +