Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more fine grained control over logging from tracers #419

Open
ivoysey opened this issue Feb 17, 2022 · 0 comments
Open

more fine grained control over logging from tracers #419

ivoysey opened this issue Feb 17, 2022 · 0 comments
Assignees

Comments

@ivoysey
Copy link
Collaborator

ivoysey commented Feb 17, 2022

right now, the tracers emit the same logs in every test. this is going to be a problem in the future at least because, when we do performance testing, we'll want to remove those commands to save gas so at the least we should be able to turn logs off. i added a boolean to mark where that will happen in 54fde19 but it should probably be a commandline flag or test option or both.

more generally: the same logs always get emitted, so if i change the code for it i often have to go back and change old tests. that's been fine so far but won't fly forever.

one approach is to define a JSON field of logging shim code in the test file that gets inserted into the tracers per-test, or a file name to read and get inserted so that at least you don't have to recompile the compiler every time you want to emit different logs.

@ivoysey ivoysey self-assigned this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant