Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the implementation of inferAndCheckExpr in Checker.scala #381

Open
ivoysey opened this issue Nov 1, 2021 · 0 comments
Open

update the implementation of inferAndCheckExpr in Checker.scala #381

ivoysey opened this issue Nov 1, 2021 · 0 comments
Assignees
Labels

Comments

@ivoysey
Copy link
Collaborator

ivoysey commented Nov 1, 2021

from the comment at the top of the function:


      * TODO: document the invariants of this function. at several call sites, we assume that the
      *   annotation in the expression returned matches the type returned (and therefore to not call
      *   ParserUtil.updateExprType to enforce that). That invariant is held in some of the returns
      *   below, but not all of them. It should be all of them, and that should be documented here.
      *   It's possible that changing the code to enforce that may break test cases, but unlikely.
      *   The typechecker tests we have now do not have perfect coverage; I believe many of them
      *   would fail because of the lack of this invariant if it was larger.
@ivoysey ivoysey added the bug label Nov 1, 2021
@ivoysey ivoysey self-assigned this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant