Skip to content

Commit 34ddf2f

Browse files
authored
Merge pull request Shopify#533 from Shopify/build-coverage
Move coverage into build/coverage
2 parents 04577dc + ba0de58 commit 34ddf2f

File tree

6 files changed

+4
-10
lines changed

6 files changed

+4
-10
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
node_modules
22
/build
3-
/coverage
43
/build-intermediate
54
/build-esnext
65
/docs

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ node_modules
44
/build-intermediate
55
/build-esnext
66
/docs
7-
/coverage
87
/esnext
98
/types
109
/index.*

.prettierignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
node_modules
22
/build
3-
/coverage
43
/build-intermediate
54
/build-esnext
65
/docs

.stylelintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
node_modules
22
/build
3-
/coverage
43
/build-intermediate
54
/build-esnext
65
/docs

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"check": "npm-run-all lint ts test",
4040
"check:ci": "npm-run-all lint ts test:ci",
4141
"clean": "rimraf build build-esnext esnext styles types docs 'build-intermediate' 'index.*' './src/styles/polaris-tokens' './tophat/.cache' './tophat/assets' 'styles.{css,scss}'",
42-
"clean:build": "rimraf 'build/!(cache)' build-esnext esnext styles types docs 'build-intermediate' 'index.*' './src/styles/polaris-tokens' './tophat/.cache' './tophat/assets' 'styles.{css,scss}'",
42+
"clean:build": "rimraf 'build/!(cache|coverage)' build-esnext esnext styles types docs 'build-intermediate' 'index.*' './src/styles/polaris-tokens' './tophat/.cache' './tophat/assets' 'styles.{css,scss}'",
4343
"optimize": "node ./scripts/optimize.js",
4444
"prebuild": "npm-run-all clean:build optimize copy-polaris-tokens",
4545
"build": "babel-node ./scripts/build.js",

sewing-kit.config.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,9 @@ export default function sewingKitConfig(
3535
};
3636

3737
// Code coverage
38-
config.coverageDirectory = 'coverage';
39-
config.coverageReporters = ['text-summary', 'html'];
40-
if (env.isCI) {
41-
config.coverageReporters.push('lcov');
42-
}
38+
config.coverageDirectory = 'build/coverage';
39+
config.coverageReporters = ['text-summary', 'html', 'lcovonly'];
40+
4341
config.collectCoverageFrom = [
4442
'src/**/*.{ts,tsx}',
4543
'!src/test-utilities/**/*.*',

0 commit comments

Comments
 (0)