Skip to content

Commit 19e114c

Browse files
authored
[yarn tophat] Fix app loading issues on Heroku (Shopify#2027)
* Enforce NODE_ENV to be picked up in Heroku (set to 'development') * Enable sourcemaps for easier debugging
1 parent 7ac4aa7 commit 19e114c

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

app.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
"env": {
55
"YARN_PRODUCTION": {
66
"required": true
7+
},
8+
"NODE_ENV": {
9+
"required": true
710
}
811
},
912
"formation": {

tophat/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"noUnusedLocals": true,
1515
"noEmitHelpers": true,
1616
"importHelpers": true,
17-
"sourceMap": false,
17+
"sourceMap": true,
1818
"lib": ["dom", "es2015", "es2016", "es2017", "dom.iterable", "scripthost"],
1919
"resolveJsonModule": true,
2020
"declaration": true,

tophat/webpack.config.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ module.exports = {
1414
'@shopify/polaris/styles/global.scss',
1515
path.join(__dirname, 'index.tsx'),
1616
],
17+
devtool: 'source-map',
1718
output: {
1819
filename: '[name].js',
1920
path: path.resolve(__dirname, 'assets'),
@@ -70,6 +71,7 @@ module.exports = {
7071
{
7172
loader: 'awesome-typescript-loader',
7273
options: {
74+
sourceMap: true,
7375
silent: true,
7476
useBabel: true,
7577
useCache: true,

0 commit comments

Comments
 (0)