added fixer for Use Array Short Tag sniff

Author: xalopp

Sniffs/Formatting/UseArrayShortTagSniff.php

@@ -52,7 +52,21 @@ public function register()
      */
     public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
     {
-        $phpcsFile->addError('Array short tag [ ... ] must be used', $stackPtr);
+        $fix = $phpcsFile->addFixableError('Array short tag [ ... ] must be used', $stackPtr);
+
+        if ($fix) {
+            $tokens = $phpcsFile->getTokens();
+            $token  = $tokens[$stackPtr];
+
+            $phpcsFile->fixer->beginChangeset();
+            $phpcsFile->fixer->replaceToken($stackPtr, '');
+            $phpcsFile->fixer->replaceToken($token['parenthesis_opener'], '[');
+            for ($i = $stackPtr +  1; $i < $token['parenthesis_opener']; $i++) {
+                $phpcsFile->fixer->replaceToken($i, '');
+            }
+            $phpcsFile->fixer->replaceToken($token['parenthesis_closer'], ']');
+            $phpcsFile->fixer->endChangeset();
+        }
     }
 }
 

Tests/Formatting/UseArrayShortTagUnitTest.fail.inc

@@ -8,4 +8,10 @@ $b = array(
 $b = array(
     $a,
     array(4, 5, 6),
-);
+);
+
+array
+(
+    array/* will be deleted */( ),
+    array (1),  array   (3)
+);

Tests/Formatting/UseArrayShortTagUnitTest.fail.inc.fixed

@@ -0,0 +1,16 @@
+<?php
+
+$a = [1, 2, 3];
+$b = [
+    $a,
+    [4, 5, 6],
+];
+$b = [
+    $a,
+    [4, 5, 6],
+];
+
+[
+    [ ],
+    [1],  [3]
+];

Tests/Formatting/UseArrayShortTagUnitTest.php

@@ -49,6 +49,9 @@ protected function getErrorList($testFile = '')
                 4  => 1,
                 8  => 1,
                 10 => 1,
+                13 => 1,
+                15 => 1,
+                16 => 2,
             );
         }