Skip to content

Commit 0443de8

Browse files
committed
Resolved comments
1 parent b62aa23 commit 0443de8

File tree

5 files changed

+6
-1
lines changed

5 files changed

+6
-1
lines changed

src/blobtree/MaxNode.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ type MaxNodeJSON = NodeJSON;
1414
* @extends Node
1515
*/
1616
export class MaxNode extends Node {
17+
// temp vars to speed up evaluation by avoiding allocations
1718
tmp_res: ValueResultType = { v: 0, g: null, m: null };
1819
tmp_g: Vector3 = new Vector3();
1920
tmp_m: Material = new Material();

src/blobtree/MinNode.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ type MinNodeJSON = NodeJSON;
1414
* @extends Node
1515
*/
1616
export class MinNode extends Node {
17+
// temp vars to speed up evaluation by avoiding allocations
1718
tmp_res: ValueResultType = { v: 0, g: null, m: null };
1819
tmp_g: Vector3 = new Vector3();
1920
tmp_m: Material = new Material();

src/blobtree/RicciNode.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export type RicciNodeJSON = {
1717
*/
1818
export class RicciNode extends Node {
1919
ricci_n: number;
20+
// temp vars to speed up evaluation by avoiding allocations
2021
tmp_v_arr: Float32Array = new Float32Array(0);
2122
tmp_m_arr: Material[] = [];
2223
tmp_res: ValueResultType = { v: 0, g: null, m: null };

src/blobtree/ScaleNode.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ type ScaleNodeJSON = {
2121
*/
2222
export class ScaleNode extends Node {
2323
_scale: Vector3 = new Vector3(1, 1, 1);
24+
25+
// temp vars to speed up evaluation by avoiding allocations
2426
tmp_res: ValueResultType = { v: 0, g: null, m: null };
2527
tmp_g: Vector3 = new Vector3();
2628
tmp_m: Material = new Material();

src/blobtree/areas/AreaScalisTri.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class AreaScalisTri extends Area {
2727
unit_normal: Vector3;
2828
main_dir: Vector3;
2929
equal_weights: boolean;
30-
segParams: SegParam[]; // Define type for segParams as per your actual structure
30+
segParams: SegParam[];
3131
segAttr: {
3232
p0_to_p: Vector3;
3333
p0_to_p_sqrnorm: number;

0 commit comments

Comments
 (0)