Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels collapsed? #4

Open
stebo85 opened this issue Oct 26, 2020 · 2 comments
Open

Labels collapsed? #4

stebo85 opened this issue Oct 26, 2020 · 2 comments

Comments

@stebo85
Copy link
Contributor

stebo85 commented Oct 26, 2020

Dear @maxdiefenbach,

I have a weird problem in some datasets where the labels are suddenly "flipped/collapsed" for single slices, here is an example:

Slice 40 - "broken":
image

Slice 41 - ok:
image

Labels are:
3 instead of 0
0 instead of 3
0 instead of 1
0 instead of 2
2 instead of 1

Do you have an idea where I could start looking for the problem?

Thank you
Cheers
Steffen

@stebo85
Copy link
Contributor Author

stebo85 commented Oct 26, 2020

and this is the line where the error seems to surface: vatsatseg.py:335: RuntimeWarning: invalid value encountered in long_scalars
nvoxels_skin_torso_prev)

@maxdiefenbach
Copy link
Owner

Dear @maxdiefenbach,

I have a weird problem in some datasets where the labels are suddenly "flipped/collapsed" for single slices, here is an example:

Slice 40 - "broken":
image

Slice 41 - ok:
image

Labels are:
3 instead of 0
0 instead of 3
0 instead of 1
0 instead of 2
2 instead of 1

Do you have an idea where I could start looking for the problem?

I have never observed a "flipped" case like you show on the broken slice 40.
The "collapsing" happens when the most outer left and right VAT regions are not connected. In such a case, one should probably join the two disconnected VAT regions of largest bounding box area instead of only taking the one connected region with largest bounding box as happening here:

╭──────── #290 ─ vatsatseg.py ──
│ sat_label = extract_largest_label(f_mask)
│ # TODO: what to do if sat_label is not continuous?
│ # maybe check for a label with a bbox area close to the sat_label?
╰──────── #292 ─

Maybe the two problems are connected, though.

Thank you
Cheers
Steffen

I

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants