Skip to content

Commit f61f3d5

Browse files
mattmmattm
committed
Convert var to let
1 parent 910c82b commit f61f3d5

20 files changed

+77
-73
lines changed

‎js/app.jsx

+7-7
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,15 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' ),
6+
let React = require( 'react' ),
77
isInteger = require( 'is-integer' ),
88
isEmpty = require( 'lodash.isEmpty' ),
99
url = require( 'url' );
1010

1111
/**
1212
* Internal dependencies
1313
*/
14-
var canvasUtils = require( './utils/canvas-utils' ),
14+
let canvasUtils = require( './utils/canvas-utils' ),
1515
config = require( './config' ),
1616
ConversionDataForm = require( './form/conversion-data-form' ),
1717
CopyURLButton = require( './copy-url-button' ),
@@ -23,7 +23,7 @@ var canvasUtils = require( './utils/canvas-utils' ),
2323

2424
module.exports = React.createClass( {
2525
getInitialState: function() {
26-
var params = this.getURLParams(), initialState;
26+
let params = this.getURLParams(), initialState;
2727

2828
initialState = {
2929
nameA: config.variations.a.defaultName,
@@ -60,7 +60,7 @@ module.exports = React.createClass( {
6060
},
6161

6262
hasValidDataParams: function() {
63-
var params = this.getURLParams();
63+
let params = this.getURLParams();
6464

6565
return utils.isIntegerString( params.ap ) &&
6666
utils.isIntegerString( params.ac ) &&
@@ -92,13 +92,13 @@ module.exports = React.createClass( {
9292
},
9393

9494
hasGaussianDistributions: function() {
95-
var variations = this.getVariations();
95+
let variations = this.getVariations();
9696

9797
return variations.a.isGaussian() && variations.b.isGaussian();
9898
},
9999

100100
getGraphsElement: function() {
101-
var variations;
101+
let variations;
102102

103103
if ( canvasUtils.isCanvasSupported() ) {
104104
variations = this.getVariations();
@@ -125,7 +125,7 @@ module.exports = React.createClass( {
125125
},
126126

127127
render: function() {
128-
var isValid = false,
128+
let isValid = false,
129129
results;
130130

131131
if ( this.hasIntegerInputs() ) {

‎js/copy-url-button.jsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,18 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' ),
6+
let React = require( 'react' ),
77
ReactZeroClipboard = require( 'react-zeroclipboard' );
88

99
/**
1010
* Internal dependencies
1111
*/
12-
var analytics = require( './analytics' ),
12+
let analytics = require( './analytics' ),
1313
config = require( './config' );
1414

1515
module.exports = React.createClass( {
1616
getResultsURL: function() {
17-
var url, hasCustomVariationNames;
17+
let url, hasCustomVariationNames;
1818

1919
url = 'http://www.abtestcalculator.com' +
2020
'?ap=' + this.props.variations.a.participants +

‎js/executive-summary.jsx

+5-5
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' );
6+
let React = require( 'react' );
77

88
/**
99
* Internal dependencies
1010
*/
11-
var statUtils = require( './stats/stat-utils' );
11+
let statUtils = require( './stats/stat-utils' );
1212

1313
module.exports = React.createClass( {
1414

@@ -35,7 +35,7 @@ module.exports = React.createClass( {
3535
},
3636

3737
oddsOfImprovementInWords: function() {
38-
var onlyWording = this.isSignificant() ? '' : 'only ',
38+
let onlyWording = this.isSignificant() ? '' : 'only ',
3939
winningElement = this.wasTestATie() ? this.getVariationBElement() : this.getWinningVariationElement();
4040

4141
return (
@@ -47,7 +47,7 @@ module.exports = React.createClass( {
4747
},
4848

4949
getSignificanceInWords: function() {
50-
var verb = this.isSignificant() ? 'can' : 'cannot';
50+
let verb = this.isSignificant() ? 'can' : 'cannot';
5151
return <p>You {verb} be confident that this result is a consequence of the changes you made and not a result of random chance.</p>;
5252
},
5353

@@ -120,7 +120,7 @@ module.exports = React.createClass( {
120120
},
121121

122122
getOddsOfImprovement: function() {
123-
var probability = this.wasVariationBTheWinner() ? this.getProbabilityBGreaterThanA() : this.getProbabilityAGreaterThanB();
123+
let probability = this.wasVariationBTheWinner() ? this.getProbabilityBGreaterThanA() : this.getProbabilityAGreaterThanB();
124124
return Math.round( probability * 100 );
125125
},
126126

‎js/form/conversion-data-form.jsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' );
6+
let React = require( 'react' );
77

88
/**
99
* Internal dependencies
1010
*/
11-
var config = require( '../config' ),
11+
let config = require( '../config' ),
1212
constants = require( '../constants' ),
1313
ConversionDataInput = require( './conversion-data-input' ),
1414
utils = require( '../utils' );
@@ -30,7 +30,7 @@ module.exports = React.createClass( {
3030
},
3131

3232
handleKeyDown: function( event ) {
33-
var currentValue = parseInt( event.target.value );
33+
let currentValue = parseInt( event.target.value );
3434

3535
if ( event.keyCode === constants.KEY_UP ) {
3636
event.target.value = currentValue + 1;
@@ -58,7 +58,7 @@ module.exports = React.createClass( {
5858
setVariationName: function( event ) {
5959
event.preventDefault();
6060

61-
var newName = prompt( "What would you like to call this variation?", event.target.innerHTML );
61+
let newName = prompt( "What would you like to call this variation?", event.target.innerHTML );
6262

6363
if ( newName ) {
6464
event.target.innerHTML = newName;

‎js/form/conversion-data-input.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' );
6+
let React = require( 'react' );
77

88
module.exports = React.createClass( {
99
render: function() {

‎js/graphs/graph-mixin.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/**
44
* Internal dependencies
55
*/
6-
var config = require( '../config' ),
6+
let config = require( '../config' ),
77
canvasUtils = require( '../utils/canvas-utils' ),
88
Rectangle = require( './rectangle' );
99

@@ -33,7 +33,7 @@ module.exports = {
3333
},
3434

3535
convertToHiDPICanvas: function() {
36-
var pixelRatio = canvasUtils.getPixelRatio(),
36+
let pixelRatio = canvasUtils.getPixelRatio(),
3737
canvas = this.refs.canvas.getDOMNode();
3838

3939
canvas.width = config.canvas.width * pixelRatio;

‎js/graphs/improvement-graph-renderer.js

+9-9
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/**
44
* Internal dependencies
55
*/
6-
var colorUtils = require( '../utils/color-utils' ),
6+
let colorUtils = require( '../utils/color-utils' ),
77
GraphRenderer = require( './graph-renderer' ),
88
NormalDifferenceDistribution = require( '../stats/normal-difference-distribution' ),
99
NumberRange = require( '../stats/number-range' ),
@@ -42,7 +42,7 @@ ImprovementGraphRenderer.prototype.renderCenter = function() {
4242
};
4343

4444
ImprovementGraphRenderer.prototype.getCenterLineColor = function() {
45-
var color = this.distribution.mean > 0 ? this.POSITIVE_COLOR : this.NEGATIVE_COLOR;
45+
let color = this.distribution.mean > 0 ? this.POSITIVE_COLOR : this.NEGATIVE_COLOR;
4646

4747
return colorUtils.hexToTransparentRGB( color, 0.5 );
4848
};
@@ -53,15 +53,15 @@ ImprovementGraphRenderer.prototype.prepareForRender = function() {
5353
};
5454

5555
ImprovementGraphRenderer.prototype.renderNegativeCurvePart = function() {
56-
var range = new NumberRange( -Infinity, 0 );
56+
let range = new NumberRange( -Infinity, 0 );
5757

5858
this.xNegativeValues = this.distribution.getXBetween( range.min, range.max );
5959
this.yNegativeValues = this.distribution.getYForXBetween( range.min, range.max );
6060
this.renderCurvePart( this.xNegativeValues, this.yNegativeValues, this.NEGATIVE_COLOR );
6161
};
6262

6363
ImprovementGraphRenderer.prototype.renderPositiveCurvePart = function() {
64-
var range = new NumberRange( 0, Infinity ),
64+
let range = new NumberRange( 0, Infinity ),
6565
xValues = this.distribution.getXBetween( range.min, range.max ),
6666
yValues = this.distribution.getYForXBetween( range.min, range.max );
6767

@@ -79,7 +79,7 @@ ImprovementGraphRenderer.prototype.renderCurvePart = function( xValues, yValues,
7979
};
8080

8181
ImprovementGraphRenderer.prototype.renderCurveFilled = function( xValues, yValues, color ) {
82-
var maxX = Math.max.apply( Math, xValues ),
82+
let maxX = Math.max.apply( Math, xValues ),
8383
minX = Math.min.apply( Math, xValues );
8484

8585
this.ctx.beginPath();
@@ -104,11 +104,11 @@ ImprovementGraphRenderer.prototype.renderCurveOutline = function( xValues, yValu
104104
};
105105

106106
ImprovementGraphRenderer.prototype.renderAxisValues = function() {
107-
var numTicks, canvasY, points, value, canvasX;
107+
let numTicks, canvasY, points, value, canvasX;
108108

109109
numTicks = this.xAxisRange.getWidth() / this.calculateXAxisInterval() + 1;
110110
canvasY = this.rect.bottom + this.X_AXIS_TICK_FONT_SIZE + this.X_AXIS_TICK_MARGIN_TOP;
111-
for ( var i = 0, l = numTicks; i < l; i++ ) {
111+
for ( let i = 0, l = numTicks; i < l; i++ ) {
112112
points = this.xAxisRange.min + i * this.calculateXAxisInterval();
113113
value = utils.formatPercentageImprovement( this.convertPointsToPercentage( points ) );
114114
canvasX = this.rect.x + ( i / ( numTicks - 1 ) ) * this.rect.width;
@@ -117,7 +117,7 @@ ImprovementGraphRenderer.prototype.renderAxisValues = function() {
117117
};
118118

119119
ImprovementGraphRenderer.prototype.convertPointsToPercentage = function( points ) {
120-
var mean = this.getControl().proportion.mean,
120+
let mean = this.getControl().proportion.mean,
121121
ratio = (points + mean) / mean - 1;
122122

123123
return Math.round( ratio * 100 );
@@ -135,7 +135,7 @@ ImprovementGraphRenderer.prototype.calculateXAxisInterval = function() {
135135
};
136136

137137
ImprovementGraphRenderer.prototype.calculateXAxisRange = function() {
138-
var interval = this.calculateXAxisInterval();
138+
let interval = this.calculateXAxisInterval();
139139
this.xAxisRange = new NumberRange( Math.floor(this.distribution.xRange.min / interval) * interval, Math.ceil(this.distribution.xRange.max / interval) * interval );
140140
};
141141

‎js/graphs/improvement-graph.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' );
6+
let React = require( 'react' );
77

88
/**
99
* Internal dependencies
1010
*/
11-
var GraphMixin = require( './graph-mixin' ),
11+
let GraphMixin = require( './graph-mixin' ),
1212
ImprovementGraphRenderer = require( './improvement-graph-renderer' );
1313

1414
module.exports = React.createClass( {

‎js/graphs/sample-proportions-graph-renderer.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
/**
44
* External dependencies
55
*/
6-
var numeral = require( 'numeral' );
6+
let numeral = require( 'numeral' );
77

88
/**
99
* Internal dependencies
1010
*/
11-
var colorUtils = require( '../utils/color-utils' ),
11+
let colorUtils = require( '../utils/color-utils' ),
1212
GraphRenderer = require( './graph-renderer' ),
1313
NumberRange = require( '../stats/number-range' );
1414

@@ -26,7 +26,7 @@ SampleProportionsGraphRenderer.prototype.render = function() {
2626
};
2727

2828
SampleProportionsGraphRenderer.prototype.calculateXAxisRange = function() {
29-
var exactRange = this.calculateXAxisRangeExact();
29+
let exactRange = this.calculateXAxisRangeExact();
3030

3131
this.xAxisRange = new NumberRange(
3232
Math.floor( exactRange.min / this.getXAxisInterval() ) * this.getXAxisInterval(),
@@ -35,7 +35,7 @@ SampleProportionsGraphRenderer.prototype.calculateXAxisRange = function() {
3535
};
3636

3737
SampleProportionsGraphRenderer.prototype.calculateXAxisRangeExact = function() {
38-
var xAxisRange, min, max;
38+
let xAxisRange, min, max;
3939

4040
this.variations.forEach( function( variation ) {
4141
xAxisRange = variation.proportion.xRange;
@@ -50,7 +50,7 @@ SampleProportionsGraphRenderer.prototype.calculateXAxisRangeExact = function() {
5050
};
5151

5252
SampleProportionsGraphRenderer.prototype.getXAxisInterval = function() {
53-
var width = this.calculateXAxisRangeExact().getWidth();
53+
let width = this.calculateXAxisRangeExact().getWidth();
5454

5555
if ( width < 0.05 ) {
5656
return 0.01;
@@ -62,7 +62,7 @@ SampleProportionsGraphRenderer.prototype.getXAxisInterval = function() {
6262
};
6363

6464
SampleProportionsGraphRenderer.prototype.calculateYAxisRange = function() {
65-
var yAxisRange, max;
65+
let yAxisRange, max;
6666

6767
this.variations.forEach( function( variation ) {
6868
yAxisRange = variation.proportion.getYAxisRange();
@@ -118,14 +118,14 @@ SampleProportionsGraphRenderer.prototype.renderCenter = function( variation ) {
118118
};
119119

120120
SampleProportionsGraphRenderer.prototype.renderAxisValues = function() {
121-
var numTicks, canvasY, i, l, proportion, percentage, canvasX;
121+
let numTicks, canvasY;
122122

123123
numTicks = this.xAxisRange.getWidth() / this.getXAxisInterval() + 1;
124124
canvasY = this.rect.bottom + this.X_AXIS_TICK_FONT_SIZE + this.X_AXIS_TICK_MARGIN_TOP;
125-
for ( i = 0, l = numTicks; i < l; i++ ) {
126-
proportion = this.xAxisRange.min + i * this.getXAxisInterval();
127-
percentage = numeral( proportion ).format( '0%' );
128-
canvasX = this.rect.x + ( i / ( numTicks - 1 ) ) * this.rect.width;
125+
for ( let i = 0, l = numTicks; i < l; i++ ) {
126+
let proportion = this.xAxisRange.min + i * this.getXAxisInterval(),
127+
percentage = numeral( proportion ).format( '0%' ),
128+
canvasX = this.rect.x + ( i / ( numTicks - 1 ) ) * this.rect.width;
129129
this.renderAxisTextWithTick( percentage, canvasX, canvasY );
130130
}
131131
};

‎js/graphs/sample-proportions-graph.jsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' );
6+
let React = require( 'react' );
77

88
/**
99
* Internal dependencies
1010
*/
11-
var GraphMixin = require( './graph-mixin' ),
11+
let GraphMixin = require( './graph-mixin' ),
1212
SampleProportionsGraphRenderer = require( './sample-proportions-graph-renderer' );
1313

1414
module.exports = React.createClass( {

‎js/main.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,16 @@
33
/**
44
* External dependencies
55
*/
6-
var React = require( 'react' ),
6+
let React = require( 'react' ),
77
url = require( 'url' );
88

99
/**
1010
* Internal dependencies
1111
*/
12-
var analytics = require( './analytics' ),
12+
let analytics = require( './analytics' ),
1313
App = require( './app' );
1414

15-
var urlParams = url.parse( document.URL, true ).query,
15+
let urlParams = url.parse( document.URL, true ).query,
1616
hasUrlParams = urlParams.hasOwnProperty('ap') && urlParams.hasOwnProperty('ac') && urlParams.hasOwnProperty('bp') && urlParams.hasOwnProperty('bc');
1717

1818
analytics.recordEvent( 'load abtest calculator', { 'has params' : hasUrlParams } );

‎js/stats/normal-difference-distribution.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
/**
44
* Internal dependencies
55
*/
6-
var NormalDistribution = require( './normal-distribution' );
6+
let NormalDistribution = require( './normal-distribution' );
77

88
// See: http://mathworld.wolfram.com/NormalDifferenceDistribution.html
99
function NormalDifferenceDistribution( proportionA, proportionB ) {
10-
var mean = proportionB.mean - proportionA.mean;
11-
var sd = Math.sqrt( proportionA.variance + proportionB.variance );
10+
let mean = proportionB.mean - proportionA.mean,
11+
sd = Math.sqrt( proportionA.variance + proportionB.variance );
1212
NormalDistribution.call( this, mean, sd );
1313
}
1414

0 commit comments

Comments
 (0)