Skip to content

Commit bf9aff0

Browse files
Merge pull request #14 from matthiasnoback/11-problem-with-factory
merge #14 Add test case to demonstrate that #11 is not a bug (matthiasnoback) This PR was merged into matthiasnoback:master branch. Discussion ---------- |Q |A | |--- |---| |Bug Fix? |n | |New Feature? |n | |BC Breaks? |n | |Deprecations?|n | |Tests Pass? |y | |Fixed Tickets|#11| |License |MIT| |Doc PR | | Sent using [Gush](https://github.com/gushphp/gush) Commits ------- 5ec3072 Add test case to demonstrate there is no bug in this case (matthiasnoback)
2 parents 4691767 + 5ec3072 commit bf9aff0

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

Tests/Functional/Fixtures/reported_problems.yml

+12
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,15 @@ services:
1717
class: Matthias\SymfonyServiceDefinitionValidator\Tests\Functional\Fixtures\Validator
1818
factory_service: validator_builder
1919
factory_method: build
20+
21+
# Issue 11: https://github.com/matthiasnoback/symfony-service-definition-validator/issues/11
22+
# It is alright for the factory service to be private
23+
service_created_by_private_factory:
24+
class: stdClass
25+
factory_service: private_factory
26+
factory_method: create
27+
arguments:
28+
- required_argument
29+
private_factory:
30+
class: Matthias\SymfonyServiceDefinitionValidator\Tests\Functional\Fixtures\Factory
31+
private: true

0 commit comments

Comments
 (0)