Fix exception message and handling of associative array of arguments

Fixes #8. @cordoval reported a failure when an arguments array has no
numeric indexes.

The fix includes:

- Changing the exception message to be a bit clearer
- Converting an associative array of arguments to a normal array

Author: matthiasnoback

DefinitionArgumentsValidator.php

@@ -34,6 +34,6 @@ public function validate(Definition $definition)
 
         $arguments = $definition->getArguments();
 
-        $this->argumentsValidator->validate($constructor, $arguments);
+        $this->argumentsValidator->validate($constructor, array_values($arguments));
     }
 }

Exception/MissingRequiredArgumentException.php

@@ -7,7 +7,7 @@ class MissingRequiredArgumentException extends \RuntimeException implements Defi
     public function __construct($className, $parameterName)
     {
         parent::__construct(sprintf(
-            'Definition has no argument for required parameter %s',
+            'Definition for class %s has no argument for required parameter %s',
             $className,
             $parameterName
         ));

Tests/DefinitionArgumentsValidatorTest.php

@@ -73,8 +73,7 @@ public function ifNoConstructorCouldBeFoundSkipsValidation()
      */
     public function ifConstructorIsFoundValidatesUsingArgumentsValidator()
     {
-        $class = 'stdClass';
-        $definition = new Definition($class);
+        $definition = new Definition();
         $arguments = array(0 => 'argument1', 1 => 'argument2');
         $definition->setArguments($arguments);
 
@@ -97,6 +96,36 @@ public function ifConstructorIsFoundValidatesUsingArgumentsValidator()
         $validator->validate($definition);
     }
 
+    /**
+     * @test
+     */
+    public function itConvertsAnAssociativeArrayOfArgumentsToANumericallyIndexedOrderedArray()
+    {
+        $definition = new Definition();
+        $arguments = array('named_argument1' => 'argument1', 'named_argument2' => 'argument2');
+        $definition->setArguments($arguments);
+
+        $numericallyIndexedArguments = array('argument1', 'argument2');
+
+        $constructorMethod = new \ReflectionMethod('Matthias\SymfonyServiceDefinitionValidator\Tests\Fixtures\ClassWithConstructor', '__construct');
+        $argumentsValidator = $this->createMockArgumentsValidator();
+        $argumentsValidator
+            ->expects($this->once())
+            ->method('validate')
+            ->with($this->equalTo($constructorMethod), $this->identicalTo($numericallyIndexedArguments));
+
+        $constructorResolver = $this->createMockConstructorResolver();
+        $constructorResolver
+            ->expects($this->once())
+            ->method('resolve')
+            ->with($definition)
+            ->will($this->returnValue($constructorMethod));
+
+        $validator = new DefinitionArgumentsValidator($constructorResolver, $argumentsValidator);
+
+        $validator->validate($definition);
+    }
+
     private function createMockConstructorResolver()
     {
         return $this->getMock('Matthias\SymfonyServiceDefinitionValidator\ConstructorResolverInterface');

Tests/Functional/Fixtures/reported_problems.yml

@@ -0,0 +1,9 @@
+services:
+    pdo:
+        class: PDO
+        arguments:
+            dsn: "mysql:dbname=dbname;host=host"
+            user: "user"
+            password: "password"
+        calls:
+            - [setAttribute, [3, 2]]

Tests/Functional/FunctionalTest.php

@@ -8,6 +8,7 @@
 use Symfony\Component\DependencyInjection\Compiler\PassConfig;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
+use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
 
 class FunctionalTest extends \PHPUnit_Framework_TestCase
 {
@@ -33,6 +34,9 @@ public function testIfTheServiceDefinitionsAreCorrectTheContainerWillBeCompiled(
         $loader = new XmlFileLoader($this->container, new FileLocator(__DIR__ . '/Fixtures'));
         $loader->load('correct_service_definitions.xml');
 
+        $loader = new YamlFileLoader($this->container, new FileLocator(__DIR__ . '/Fixtures'));
+        $loader->load('reported_problems.yml');
+
         $this->container->compile();
     }