Skip to content

Commit 001add5

Browse files
Use PHPUnit's FilterMapper
1 parent 43201fc commit 001add5

File tree

3 files changed

+9
-26
lines changed

3 files changed

+9
-26
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,3 +2,4 @@
22
/composer.lock
33
coverage
44
.idea
5+
/.phpunit.result.cache

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ $shutDownCodeCoverage();
4646
</phpunit>
4747
```
4848

49-
Any configuration directive that's [available in PHPUnit](https://phpunit.de/manual/current/en/appendixes.configuration.html#appendixes.configuration.whitelisting-files) works for this library too.
49+
Most configuration directives that are [available in PHPUnit](https://phpunit.de/manual/current/en/appendixes.configuration.html#appendixes.configuration.whitelisting-files) work for this library too.
50+
If you notice that something doesn't work, please submit an issue.
5051

5152
If you don't provide a PHPUnit configuration file, no filters will be applied, so you will get a coverage report for all the code in your project, including vendor and test code if applicable.
5253

src/LiveCodeCoverage/CodeCoverageFactory.php

Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace LiveCodeCoverage;
44

5+
use PHPUnit\TextUI\XmlConfiguration\CodeCoverage\FilterMapper;
56
use PHPUnit\TextUI\XmlConfiguration\Configuration;
67
use PHPUnit\TextUI\XmlConfiguration\Loader;
78
use SebastianBergmann\CodeCoverage\CodeCoverage;
@@ -26,7 +27,6 @@ public static function createFromPhpUnitConfiguration($phpunitFilePath)
2627

2728
private static function configure(CodeCoverage $codeCoverage, Configuration $configuration)
2829
{
29-
$codeCoverageFilter = $codeCoverage->filter();
3030
$codeCoverageConfiguration = $configuration->codeCoverage();
3131

3232
// The following code is copied from PHPUnit\TextUI\TestRunner
@@ -44,30 +44,11 @@ private static function configure(CodeCoverage $codeCoverage, Configuration $con
4444
}
4545
}
4646

47-
foreach ($codeCoverageConfiguration->directories() as $directory) {
48-
$codeCoverageFilter->includeDirectory(
49-
$directory->path(),
50-
$directory->suffix(),
51-
$directory->prefix()
52-
);
53-
}
54-
55-
foreach ($codeCoverageConfiguration->files() as $file) {
56-
$codeCoverageFilter->includeFile($file->path());
57-
}
58-
59-
foreach ($codeCoverageConfiguration->excludeDirectories() as $directory) {
60-
$codeCoverageFilter->excludeDirectory(
61-
$directory->path(),
62-
$directory->suffix(),
63-
$directory->prefix()
64-
);
65-
}
66-
67-
foreach ($codeCoverageConfiguration->excludeFiles() as $file) {
68-
$codeCoverageFilter->excludeFile($file->path());
69-
}
70-
47+
/*
48+
* `FilterMapper` is not covered by PHPUnit's backward-compatibility promise, but let's use it instead of
49+
* copying it.
50+
*/
51+
(new FilterMapper())->map($codeCoverage->filter(), $configuration->codeCoverage());
7152
}
7253

7354
/**

0 commit comments

Comments
 (0)