Skip to content

Commit 76cfff8

Browse files
docs: clarified wording around the NodePoolUpdateStrategy default behavior (googleapis#340)
* docs: clarified wording around the NodePoolUpdateStrategy default behavior docs: add references for available node image types PiperOrigin-RevId: 505182579 Source-Link: googleapis/googleapis@c062caf Source-Link: https://github.com/googleapis/googleapis-gen/commit/ea6906f11af5243d6b4105af0af854e878b0a1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWE2OTA2ZjExYWY1MjQzZDZiNDEwNWFmMGFmODU0ZTg3OGIwYTFlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: clarified wording around the NodePoolUpdateStrategy default behavior docs: add references for available node image types PiperOrigin-RevId: 505186848 Source-Link: googleapis/googleapis@d6e9adb Source-Link: https://github.com/googleapis/googleapis-gen/commit/fa221b6a3c945ca7ec063b72ae9eca940ed3dfdd Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZmEyMjFiNmEzYzk0NWNhN2VjMDYzYjcyYWU5ZWNhOTQwZWQzZGZkZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent c0472c8 commit 76cfff8

File tree

2 files changed

+24
-6
lines changed

2 files changed

+24
-6
lines changed

google/cloud/container_v1/types/cluster_service.py

+12-3
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,9 @@ class NodePoolUpdateStrategy(proto.Enum):
240240
241241
Values:
242242
NODE_POOL_UPDATE_STRATEGY_UNSPECIFIED (0):
243-
Default value.
243+
Default value if unset. GKE internally
244+
defaults the update strategy to SURGE for
245+
unspecified strategies.
244246
BLUE_GREEN (2):
245247
blue-green upgrade.
246248
SURGE (3):
@@ -523,7 +525,9 @@ class NodeConfig(proto.Message):
523525
image_type (str):
524526
The image type to use for this node. Note
525527
that for a given image type, the latest version
526-
of it will be used.
528+
of it will be used. Please see
529+
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
530+
for available image types.
527531
labels (MutableMapping[str, str]):
528532
The map of Kubernetes labels (key/value
529533
pairs) to be applied to each node. These will
@@ -3584,7 +3588,9 @@ class UpdateNodePoolRequest(proto.Message):
35843588
master version
35853589
image_type (str):
35863590
Required. The desired image type for the node
3587-
pool.
3591+
pool. Please see
3592+
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
3593+
for available image types.
35883594
name (str):
35893595
The name (project, location, cluster, node pool) of the node
35903596
pool to update. Specified in the format
@@ -5885,6 +5891,9 @@ class AutoprovisioningNodePoolDefaults(proto.Message):
58855891
https://cloud.google.com/compute/docs/disks/customer-managed-encryption
58865892
image_type (str):
58875893
The image type to use for NAP created node.
5894+
Please see
5895+
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
5896+
for available image types.
58885897
"""
58895898

58905899
oauth_scopes: MutableSequence[str] = proto.RepeatedField(

google/cloud/container_v1beta1/types/cluster_service.py

+12-3
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,9 @@ class NodePoolUpdateStrategy(proto.Enum):
233233
234234
Values:
235235
NODE_POOL_UPDATE_STRATEGY_UNSPECIFIED (0):
236-
Default value.
236+
Default value if unset. GKE internally
237+
defaults the update strategy to SURGE for
238+
unspecified strategies.
237239
BLUE_GREEN (2):
238240
blue-green upgrade.
239241
SURGE (3):
@@ -520,7 +522,9 @@ class NodeConfig(proto.Message):
520522
image_type (str):
521523
The image type to use for this node. Note
522524
that for a given image type, the latest version
523-
of it will be used.
525+
of it will be used. Please see
526+
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
527+
for available image types.
524528
labels (MutableMapping[str, str]):
525529
The map of Kubernetes labels (key/value
526530
pairs) to be applied to each node. These will
@@ -4083,7 +4087,9 @@ class UpdateNodePoolRequest(proto.Message):
40834087
master version
40844088
image_type (str):
40854089
Required. The desired image type for the node
4086-
pool.
4090+
pool. Please see
4091+
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
4092+
for available image types.
40874093
locations (MutableSequence[str]):
40884094
The desired list of Google Compute Engine
40894095
`zones <https://cloud.google.com/compute/docs/zones#available>`__
@@ -6468,6 +6474,9 @@ class AutoprovisioningNodePoolDefaults(proto.Message):
64686474
https://cloud.google.com/compute/docs/disks/customer-managed-encryption
64696475
image_type (str):
64706476
The image type to use for NAP created node.
6477+
Please see
6478+
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images
6479+
for available image types.
64716480
"""
64726481

64736482
oauth_scopes: MutableSequence[str] = proto.RepeatedField(

0 commit comments

Comments
 (0)