-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernizing asyncio
usage in examples
#4
Comments
Ah and just to justify this request, for our use case we will be deploying the probe tasks as part of existing mostly |
I'd prefer to keep everything compatible with other compatible with older versions of Python, unless there is some compelling reason to do otherwise. I explicitly wrote the code to be compatible as far back as Python 3.5. I don't really understand the implications of your second comment. Is there some reason that this module is unsuitable for your purposes as-is? |
Not particularly, but it could be more compatible by leveraging the task groups in terms of errors due to connectivity failures; error bubbling is easier to capture when SC constraints are in place. FWIW i'm only proposing changing come examples, we could even just have a 3.11+ version of the particular use we have.
👍🏼 totally get it. |
If you want to open a PR adding a new example in the style you think is best for modern Python usage, that seems reasonable. I'd like to keep the existing ones compatible with Python 3.5. |
Would this be something you'd accept as a PR?
For example making changes like:
loop.run_until_complete()
toasyncio.run()
.ensure_future()
with the newerasyncio.create_task()
where you'd prefer to not use task groups.Super dope lib btw 😎
Lookin forward to using it in a serious project 🏄🏼
The text was updated successfully, but these errors were encountered: