Skip to content

Commit 7f80ed0

Browse files
committed
shorter name
1 parent 57b1930 commit 7f80ed0

File tree

3 files changed

+12
-39
lines changed

3 files changed

+12
-39
lines changed

crates/matrix-sdk-ui/src/timeline/pagination.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,7 @@ impl super::Timeline {
2929
pub async fn paginate_backwards(&self, num_events: u16) -> Result<bool, Error> {
3030
if self.inner.is_live().await {
3131
Ok(self
32-
.live_paginate_backwards_with_options(PaginationOptions::until_num_items(
33-
num_events, 20,
34-
))
32+
.live_paginate_backwards(PaginationOptions::until_num_items(num_events, 20))
3533
.await?)
3634
} else {
3735
Ok(self.focused_paginate_backwards(num_events.into()).await?)
@@ -63,7 +61,7 @@ impl super::Timeline {
6361
///
6462
/// Returns whether we hit the start of the timeline.
6563
#[instrument(skip_all, fields(room_id = ?self.room().room_id(), ?options))]
66-
pub async fn live_paginate_backwards_with_options(
64+
pub async fn live_paginate_backwards(
6765
&self,
6866
mut options: PaginationOptions<'_>,
6967
) -> event_cache::Result<bool> {

crates/matrix-sdk-ui/tests/integration/timeline/pagination.rs

Lines changed: 9 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,7 @@ async fn test_back_pagination() {
7171
.await;
7272

7373
let paginate = async {
74-
timeline
75-
.live_paginate_backwards_with_options(PaginationOptions::simple_request(10))
76-
.await
77-
.unwrap();
74+
timeline.live_paginate_backwards(PaginationOptions::simple_request(10)).await.unwrap();
7875
server.reset().await;
7976
};
8077
let observe_paginating = async {
@@ -133,10 +130,7 @@ async fn test_back_pagination() {
133130
.mount(&server)
134131
.await;
135132

136-
timeline
137-
.live_paginate_backwards_with_options(PaginationOptions::simple_request(10))
138-
.await
139-
.unwrap();
133+
timeline.live_paginate_backwards(PaginationOptions::simple_request(10)).await.unwrap();
140134
assert_next_eq!(back_pagination_status, PaginationStatus::TimelineEndReached);
141135
}
142136

@@ -201,10 +195,7 @@ async fn test_back_pagination_highlighted() {
201195
.mount(&server)
202196
.await;
203197

204-
timeline
205-
.live_paginate_backwards_with_options(PaginationOptions::simple_request(10))
206-
.await
207-
.unwrap();
198+
timeline.live_paginate_backwards(PaginationOptions::simple_request(10)).await.unwrap();
208199
server.reset().await;
209200

210201
let first = assert_next_matches!(
@@ -272,9 +263,7 @@ async fn test_wait_for_token() {
272263

273264
let paginate = async {
274265
timeline
275-
.live_paginate_backwards_with_options(
276-
PaginationOptions::simple_request(10).wait_for_token(),
277-
)
266+
.live_paginate_backwards(PaginationOptions::simple_request(10).wait_for_token())
278267
.await
279268
.unwrap();
280269
};
@@ -339,16 +328,10 @@ async fn test_dedup() {
339328

340329
// If I try to paginate twice at the same time,
341330
let paginate_1 = async {
342-
timeline
343-
.live_paginate_backwards_with_options(PaginationOptions::simple_request(10))
344-
.await
345-
.unwrap();
331+
timeline.live_paginate_backwards(PaginationOptions::simple_request(10)).await.unwrap();
346332
};
347333
let paginate_2 = async {
348-
timeline
349-
.live_paginate_backwards_with_options(PaginationOptions::simple_request(10))
350-
.await
351-
.unwrap();
334+
timeline.live_paginate_backwards(PaginationOptions::simple_request(10)).await.unwrap();
352335
};
353336
timeout(Duration::from_secs(5), join(paginate_1, paginate_2)).await.unwrap();
354337

@@ -439,9 +422,7 @@ async fn test_timeline_reset_while_paginating() {
439422

440423
let paginate = async {
441424
timeline
442-
.live_paginate_backwards_with_options(
443-
PaginationOptions::simple_request(10).wait_for_token(),
444-
)
425+
.live_paginate_backwards(PaginationOptions::simple_request(10).wait_for_token())
445426
.await
446427
.unwrap();
447428
};
@@ -579,10 +560,7 @@ async fn test_empty_chunk() {
579560
.await;
580561

581562
let paginate = async {
582-
timeline
583-
.live_paginate_backwards_with_options(PaginationOptions::simple_request(10))
584-
.await
585-
.unwrap();
563+
timeline.live_paginate_backwards(PaginationOptions::simple_request(10)).await.unwrap();
586564
server.reset().await;
587565
};
588566
let observe_paginating = async {
@@ -681,10 +659,7 @@ async fn test_until_num_items_with_empty_chunk() {
681659
.await;
682660

683661
let paginate = async {
684-
timeline
685-
.live_paginate_backwards_with_options(PaginationOptions::until_num_items(4, 4))
686-
.await
687-
.unwrap();
662+
timeline.live_paginate_backwards(PaginationOptions::until_num_items(4, 4)).await.unwrap();
688663
server.reset().await;
689664
};
690665
let observe_paginating = async {

labs/multiverse/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ impl App {
344344
// have been added.
345345
*pagination = Some(spawn(async move {
346346
if let Err(err) = sdk_timeline
347-
.live_paginate_backwards_with_options(PaginationOptions::until_num_items(20, 10))
347+
.live_paginate_backwards(PaginationOptions::until_num_items(20, 10))
348348
.await
349349
{
350350
// TODO: would be nice to be able to set the status

0 commit comments

Comments
 (0)