clean up code to use override keyword and range-based for loops

Author: duncanpo

api/baggage/include/opentelemetry-matlab/baggage/BaggagePropagatorProxy.h

@@ -22,7 +22,7 @@ class BaggagePropagatorProxy : public TextMapPropagatorProxy {
 
     // getUniquePtrCopy is used by CompositePropagator, which needs a unique_ptr instance
     // Takes the BaggagePropagator object inside the shared_ptr, make a copy, and wrap the copy in a unique_ptr 
-    virtual std::unique_ptr<context_propagation::TextMapPropagator> getUniquePtrCopy() {
+    virtual std::unique_ptr<context_propagation::TextMapPropagator> getUniquePtrCopy() override {
         return std::unique_ptr<context_propagation::TextMapPropagator>(
 			new baggage_propagation::BaggagePropagator(
 				*static_cast<baggage_propagation::BaggagePropagator*>(CppPropagator.get())));

api/baggage/src/BaggageProxy.cpp

@@ -77,9 +77,8 @@ void BaggageProxy::setEntries(libmexclass::proxy::method::Context& context) {
 
 void BaggageProxy::deleteEntries(libmexclass::proxy::method::Context& context) {
     matlab::data::StringArray keys_mda = context.inputs[0];
-    size_t nkeys = keys_mda.getNumberOfElements();
-    for (size_t i = 0; i < nkeys; ++i) {
-        CppBaggage = CppBaggage->Delete(static_cast<std::string>(keys_mda[i]));
+    for (auto key : keys_mda) {
+        CppBaggage = CppBaggage->Delete(static_cast<std::string>(key));
     }
 }
 

api/context/src/CompositePropagatorProxy.cpp

@@ -16,8 +16,7 @@ CompositePropagatorProxy::CompositePropagatorProxy(const libmexclass::proxy::Fun
     std::vector<std::unique_ptr<context_propagation::TextMapPropagator> > propagators;
     propagators.reserve(npropagators);
 
-    for (size_t i=0; i < npropagators; ++i) {
-	libmexclass::proxy::ID propagatorid = propagatorid_mda[i];
+    for (auto propagatorid : propagatorid_mda) {
         propagators.push_back(std::static_pointer_cast<TextMapPropagatorProxy>(
 		   libmexclass::proxy::ProxyManager::getProxy(propagatorid))->getUniquePtrCopy());
     }

api/trace/include/opentelemetry-matlab/trace/TraceContextPropagatorProxy.h

@@ -22,7 +22,7 @@ class TraceContextPropagatorProxy : public TextMapPropagatorProxy {
 
     // getUniquePtrCopy is used by CompositePropagator, which needs a unique_ptr instance
     // Takes the BaggagePropagator object inside the shared_ptr, make a copy, and wrap the copy in a unique_ptr 
-    virtual std::unique_ptr<context_propagation::TextMapPropagator> getUniquePtrCopy() {
+    virtual std::unique_ptr<context_propagation::TextMapPropagator> getUniquePtrCopy() override {
         return std::unique_ptr<context_propagation::TextMapPropagator>(
 			new trace_propagation::HttpTraceContext(
 				*static_cast<trace_propagation::HttpTraceContext*>(CppPropagator.get())));

exporters/otlp/include/opentelemetry-matlab/exporters/otlp/OtlpGrpcSpanExporterProxy.h

@@ -18,7 +18,7 @@ class OtlpGrpcSpanExporterProxy: public libmexclass::opentelemetry::sdk::SpanExp
   public:
     OtlpGrpcSpanExporterProxy(const libmexclass::proxy::FunctionArguments& constructor_arguments);
 
-    std::unique_ptr<trace_sdk::SpanExporter> getInstance();
+    std::unique_ptr<trace_sdk::SpanExporter> getInstance() override;
 
     void getDefaultOptionValues(libmexclass::proxy::method::Context& context);
 

exporters/otlp/include/opentelemetry-matlab/exporters/otlp/OtlpHttpSpanExporterProxy.h

@@ -18,7 +18,7 @@ class OtlpHttpSpanExporterProxy: public libmexclass::opentelemetry::sdk::SpanExp
   public:
     OtlpHttpSpanExporterProxy(const libmexclass::proxy::FunctionArguments& constructor_arguments);
 
-    std::unique_ptr<trace_sdk::SpanExporter> getInstance();
+    std::unique_ptr<trace_sdk::SpanExporter> getInstance() override;
 
     void getDefaultOptionValues(libmexclass::proxy::method::Context& context);
 

sdk/trace/include/opentelemetry-matlab/sdk/trace/AlwaysOffSamplerProxy.h

@@ -16,7 +16,7 @@ class AlwaysOffSamplerProxy : public SamplerProxy {
   public:
     AlwaysOffSamplerProxy(const libmexclass::proxy::FunctionArguments& constructor_arguments) {}
 
-    std::unique_ptr<trace_sdk::Sampler> getInstance() {
+    std::unique_ptr<trace_sdk::Sampler> getInstance() override {
         return trace_sdk::AlwaysOffSamplerFactory::Create();
     }
 };

sdk/trace/include/opentelemetry-matlab/sdk/trace/AlwaysOnSamplerProxy.h

@@ -16,7 +16,7 @@ class AlwaysOnSamplerProxy : public SamplerProxy {
   public:
     AlwaysOnSamplerProxy(const libmexclass::proxy::FunctionArguments& constructor_arguments) {}
 
-    std::unique_ptr<trace_sdk::Sampler> getInstance() {
+    std::unique_ptr<trace_sdk::Sampler> getInstance() override {
         return trace_sdk::AlwaysOnSamplerFactory::Create();
     }
 };

sdk/trace/include/opentelemetry-matlab/sdk/trace/BatchSpanProcessorProxy.h

@@ -17,7 +17,7 @@ class BatchSpanProcessorProxy : public SpanProcessorProxy {
   public:
     BatchSpanProcessorProxy(const libmexclass::proxy::FunctionArguments& constructor_arguments);
 
-    std::unique_ptr<trace_sdk::SpanProcessor> getInstance();
+    std::unique_ptr<trace_sdk::SpanProcessor> getInstance() override;
 
     void getDefaultOptionValues(libmexclass::proxy::method::Context& context);
 

sdk/trace/include/opentelemetry-matlab/sdk/trace/ParentBasedSamplerProxy.h

@@ -14,7 +14,7 @@ class ParentBasedSamplerProxy : public SamplerProxy {
   public:
     ParentBasedSamplerProxy(const libmexclass::proxy::FunctionArguments& constructor_arguments); 
 
-    std::unique_ptr<trace_sdk::Sampler> getInstance();
+    std::unique_ptr<trace_sdk::Sampler> getInstance() override;
 
   private:
     std::shared_ptr<trace_sdk::Sampler> DelegateSampler;