-
Notifications
You must be signed in to change notification settings - Fork 2
Update python setup logic #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
35f9ad2
Update python setup logic
krisfed 3f218c9
Always use py.importlib.import_module and a method to get ZarrPy pyth…
krisfed d9bbc99
Do not need to avoid doing import_module multiple times. Add a test f…
krisfed 88563e7
Make sure the module is already on the path in the reload method
krisfed a04a72a
Python error change
krisfed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
classdef tZarr < SharedZarrTestSetup | ||
% Tests for Zarr class methods | ||
|
||
% Copyright 2025 The MathWorks, Inc. | ||
|
||
methods(Test) | ||
|
||
function verifySupportedCloudPatterns(testcase) | ||
% Verify that the bucket name and the array path can be | ||
% extracted successfully if a cloud path is used as an input. | ||
|
||
% This list contains path pattern currently supported by Zarr | ||
% in MATLAB. Any invalid path not matching any of these | ||
% patterns will result in an error. | ||
inpPath = {'https://mybucket.s3.us-west-2.amazonaws.com/path/to/myZarrFile', ... | ||
'https://mybucket.s3.amazonaws.com/path/to/myZarrFile', ... | ||
'https://mybucket.s3.custom-endpoint.org/path/to/myZarrFile', ... | ||
'https://s3.amazonaws.com/mybucket/path/to/myZarrFile', ... | ||
'https://s3.eu-central-1.example.edu/mybucket/path/to/myZarrFile', ... | ||
's3://mybucket/path/to/myZarrFile'}; | ||
|
||
for i = 1:length(inpPath) | ||
[bucketName, objectPath] = Zarr.extractS3BucketNameAndPath(inpPath{i}); | ||
testcase.verifyEqual(bucketName, 'mybucket', ['Bucket name extraction failed for ' inpPath{i}]); | ||
testcase.verifyEqual(objectPath, 'path/to/myZarrFile', ['Object path extraction failed for ' inpPath{i}]); | ||
end | ||
end | ||
|
||
function verifyReload(testcase) | ||
% Verify that calling reload method does not cause any issues | ||
|
||
Zarr.pyReloadInProcess() | ||
zarrPyModule = Zarr.ZarrPy; | ||
testcase.verifyTrue(isa(zarrPyModule, 'py.module')) | ||
|
||
end | ||
|
||
|
||
end | ||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NM, I missed the tests. Is it only for the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for development convenience. If Python is in-process and we modify the Python code, this method can be used after
clear classes
to reload the Python module to pick up the code changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhh- you could do something like having a constant hidden property that cleans up and executes that function so
clear classes
would do this automagically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've discussed different approaches with external interface team and didn't arrive to anything much cleaner, so time-boxed it to this solution. But will follow up with you offline to see if we can improve it.