tests: add tests for errors related to adding keys

These are ported from the libkeyutils test suite
(tests/keyctl/add/bad-args).

Author: mathstuf

src/tests/add.rs

@@ -0,0 +1,111 @@
+// Copyright (c) 2019, Ben Boeckel
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without modification,
+// are permitted provided that the following conditions are met:
+//
+//     * Redistributions of source code must retain the above copyright notice,
+//       this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above copyright notice,
+//       this list of conditions and the following disclaimer in the documentation
+//       and/or other materials provided with the distribution.
+//     * Neither the name of this project nor the names of its contributors
+//       may be used to endorse or promote products derived from this software
+//       without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+// ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+// WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
+// ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+// (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+// LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+// ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+use std::iter;
+
+use crate::{Keyring, KeyringSerial, SpecialKeyring};
+use crate::keytypes::User;
+
+use super::utils::kernel::*;
+use super::utils::keys::*;
+
+#[test]
+fn empty_key_type() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    let err = keyring.add_key::<EmptyKey, _, _>("", ()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::EINVAL));
+}
+
+#[test]
+fn unsupported_key_type() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    let err = keyring.add_key::<UnsupportedKey, _, _>("", ()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::ENODEV));
+}
+
+#[test]
+fn invalid_key_type() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    let err = keyring.add_key::<InvalidKey, _, _>("", ()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::EPERM));
+}
+
+#[test]
+fn maxlen_key_type() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    let err = keyring.add_key::<MaxLenKey, _, _>("", ()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::ENODEV));
+}
+
+#[test]
+fn overlong_key_type() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    let err = keyring.add_key::<OverlongKey, _, _>("", ()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::EINVAL));
+}
+
+#[test]
+fn keyring_with_payload() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    let err = keyring.add_key::<KeyringShadow, _, _>("", "payload").unwrap_err();
+    assert_eq!(err, errno::Errno(libc::EINVAL));
+}
+
+#[test]
+fn max_user_description() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    // Subtract one because the NUL is added in the kernel API.
+    let maxdesc: String = iter::repeat('a').take(*PAGE_SIZE - 1).collect();
+    let res = keyring.add_key::<User, _, _>(maxdesc.as_ref(), "payload".as_bytes());
+    // If the user's quota is smaller than this, it's an error.
+    if KEY_INFO.maxbytes < *PAGE_SIZE {
+        assert_eq!(res.unwrap_err(), errno::Errno(libc::EDQUOT));
+    } else {
+        let key = res.unwrap();
+        assert_eq!(key.description().unwrap().description, maxdesc);
+        key.invalidate().unwrap();
+    }
+}
+
+#[test]
+fn overlong_user_description() {
+    let mut keyring = Keyring::attach_or_create(SpecialKeyring::Process).unwrap();
+    // On MIPS with < 3.19, there is a bug where this is allowed. 3.19 was released in Feb 2015,
+    // so this is being ignored here.
+    let toolarge: String = iter::repeat('a').take(*PAGE_SIZE).collect();
+    let err = keyring.add_key::<User, _, _>(toolarge.as_ref(), "payload".as_bytes()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::EINVAL));
+}
+
+#[test]
+fn invalid_keyring() {
+    // Yes, we're explicitly breaking the NonZeroI32 rules here. However, it is not passing
+    // through any bits which care (e.g., `Option`), so this is purely to test that using an
+    // invalid keyring ID gives back `EINVAL` as expected.
+    let mut keyring = unsafe { Keyring::new(KeyringSerial::new_unchecked(0)) };
+    let err = keyring.add_key::<User, _, _>("desc", "payload".as_bytes()).unwrap_err();
+    assert_eq!(err, errno::Errno(libc::EINVAL));
+}

src/tests/mod.rs

@@ -27,3 +27,5 @@
 //! The test structure here comes from the structure in libkeyutils.
 
 mod utils;
+
+mod add;

src/tests/utils/keys.rs

@@ -0,0 +1,93 @@
+// Copyright (c) 2019, Ben Boeckel
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without modification,
+// are permitted provided that the following conditions are met:
+//
+//     * Redistributions of source code must retain the above copyright notice,
+//       this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above copyright notice,
+//       this list of conditions and the following disclaimer in the documentation
+//       and/or other materials provided with the distribution.
+//     * Neither the name of this project nor the names of its contributors
+//       may be used to endorse or promote products derived from this software
+//       without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+// ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+// WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+// DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR
+// ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+// (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+// LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+// ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+// SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+use crate::KeyType;
+
+pub struct EmptyKey;
+
+impl KeyType for EmptyKey {
+    type Description = str;
+    type Payload = ();
+
+    fn name() -> &'static str {
+        ""
+    }
+}
+
+pub struct UnsupportedKey;
+
+impl KeyType for UnsupportedKey {
+    type Description = str;
+    type Payload = ();
+
+    fn name() -> &'static str {
+        "unsupported_key_type"
+    }
+}
+
+pub struct InvalidKey;
+
+impl KeyType for InvalidKey {
+    type Description = str;
+    type Payload = ();
+
+    fn name() -> &'static str {
+        ".invalid_key_type"
+    }
+}
+
+pub struct MaxLenKey;
+
+impl KeyType for MaxLenKey {
+    type Description = str;
+    type Payload = ();
+
+    fn name() -> &'static str {
+        "1234567890123456789012345678901"
+    }
+}
+
+pub struct OverlongKey;
+
+impl KeyType for OverlongKey {
+    type Description = str;
+    type Payload = ();
+
+    fn name() -> &'static str {
+        "12345678901234567890123456789012"
+    }
+}
+
+pub struct KeyringShadow;
+
+impl KeyType for KeyringShadow {
+    type Description = str;
+    type Payload = str;
+
+    fn name() -> &'static str {
+        "keyring"
+    }
+}

src/tests/utils/mod.rs

@@ -25,3 +25,4 @@
 // SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 pub mod kernel;
+pub mod keys;