Somewhat naive rails 6 compatible pagination

Author: maths22

Gemfile

@@ -7,9 +7,8 @@ when 'mongoid' then
   gem 'mongoid-scroll'
   gem 'mongoid-shell'
 when 'activerecord' then
-  gem 'activerecord', '~> 5.0.0'
-  gem 'otr-activerecord', '~> 1.2.1'
-  gem 'cursor_pagination' # rubocop:disable Bundler/OrderedGems
+  gem 'activerecord'
+  gem 'otr-activerecord'
   gem 'pg'
 when nil
   warn "Missing ENV['DATABASE_ADAPTER']."

lib/slack-ruby-bot-server/api/endpoints/teams_endpoint.rb

@@ -84,7 +84,7 @@ class TeamsEndpoint < Grape::API
             if team
               team.ping_if_active!
 
-              team.update_attributes!(
+              team.update!(
                 oauth_version: oauth_version,
                 oauth_scope: oauth_scope,
                 activated_user_id: user_id,

lib/slack-ruby-bot-server/api/helpers/cursor_helpers.rb

@@ -31,14 +31,20 @@ def paginate_by_cursor(coll, options)
             results = { results: [], next: nil }
             size = (params[:size] || 10).to_i
             results[:total_count] = coll.count(:all) if params[:total_count]
-            coll = coll.offset(params[:offset].to_i) if params.key?(:offset)
+            limited_coll = coll
+            limited_coll = coll.offset(params[:offset].to_i) if params.key?(:offset)
             sort_options = {}
             sort_order(options).each do |order|
-              sort_options[order[:column]] = { reverse: true } if order[:direction] == :desc
+              sort_options[order[:column]] = order[:direction]
+            end
+            limited_coll = limited_coll.where(sort_options['id'] == :desc ? 'id <= ?' : 'id >= ?', params[:cursor]) if params[:cursor]
+            limited_coll = limited_coll.order(sort_options).limit(size)
+            results[:results] = limited_coll.to_a
+            if sort_options['id'] == :desc
+              results[:next] = limited_coll.last.id - 1 unless coll.where('id <= ?', limited_coll.last.id - 1).length.zero?
+            else
+              results[:next] = limited_coll.last.id + 1 unless coll.where('id >= ?', limited_coll.last.id + 1).length.zero?
             end
-            coll = coll.cursor(params[:cursor], columns: sort_options).per(size)
-            results[:results] = coll.to_a
-            results[:next] = coll.next_cursor.to_s unless coll.last_page?
             results
           end
         end

lib/slack-ruby-bot-server/models/team/methods.rb

@@ -13,11 +13,11 @@ module Methods
     validates_presence_of :team_id
 
     def deactivate!
-      update_attributes!(active: false)
+      update!(active: false)
     end
 
     def activate!(token)
-      update_attributes!(active: true, token: token)
+      update!(active: true, token: token)
     end
 
     def to_s