Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to wait after Wire.requestFrom() and it should not be followed by Wire.endTransmission(). #27

Closed
Koepel opened this issue Jun 28, 2019 · 1 comment

Comments

@Koepel
Copy link

Koepel commented Jun 28, 2019

In the file "Radio/src/SI4703.cpp" the waiting after a Wire.requestFrom() may be removed. It is this line: while(Wire.available() < 32) ;

In the file "Radio/src/RDA5807M.cpp" the Wire.requestFrom() is followed by a Wire.endTransmission() in four places. Those Wire.endTransmission() may be removed.

Explanation: Common-mistakes, number 1 and 2.

@mathertel
Copy link
Owner

added changes to the code. Waiting for test results before creating new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants