Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit cabeabc

Browse files
authored
chore(package): Remove need for selection-control (#4442)
1 parent f441f8f commit cabeabc

File tree

16 files changed

+12
-99
lines changed

16 files changed

+12
-99
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@
185185
"ripple",
186186
"rtl",
187187
"select",
188-
"selection-control",
189188
"shape",
190189
"slider",
191190
"snackbar",

packages/material-components-web/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ import * as notchedOutline from '@material/notched-outline/index';
4141
import * as radio from '@material/radio/index';
4242
import * as ripple from '@material/ripple/index';
4343
import * as select from '@material/select/index';
44-
import * as selectionControl from '@material/selection-control/index';
4544
import * as slider from '@material/slider/index';
4645
import * as snackbar from '@material/snackbar/index';
4746
import * as switchControl from '@material/switch/index';
@@ -102,7 +101,6 @@ export {
102101
radio,
103102
ripple,
104103
select,
105-
selectionControl,
106104
slider,
107105
snackbar,
108106
switchControl,

packages/material-components-web/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
"@material/ripple": "^0.44.1",
4343
"@material/rtl": "^0.42.0",
4444
"@material/select": "^0.44.1",
45-
"@material/selection-control": "^0.44.1",
4645
"@material/shape": "^0.44.1",
4746
"@material/slider": "^0.44.1",
4847
"@material/snackbar": "^0.44.1",

packages/mdc-checkbox/component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,14 @@ import {getCorrectEventName} from '@material/animation/util';
2525
import {MDCComponent} from '@material/base/component';
2626
import {ponyfill} from '@material/dom/index';
2727
import {MDCRipple, MDCRippleAdapter, MDCRippleCapableSurface, MDCRippleFoundation} from '@material/ripple/index';
28-
import {MDCSelectionControl} from '@material/selection-control/types';
2928
import {MDCCheckboxAdapter} from './adapter';
3029
import {MDCCheckboxFoundation} from './foundation';
3130

3231
const {NATIVE_CONTROL_SELECTOR} = MDCCheckboxFoundation.strings;
3332

3433
const CB_PROTO_PROPS = ['checked', 'indeterminate'];
3534

36-
export class MDCCheckbox extends MDCComponent<MDCCheckboxFoundation>
37-
implements MDCSelectionControl, MDCRippleCapableSurface {
35+
export class MDCCheckbox extends MDCComponent<MDCCheckboxFoundation> implements MDCRippleCapableSurface {
3836

3937
static attachTo(root: Element) {
4038
return new MDCCheckbox(root);

packages/mdc-checkbox/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"@material/feature-targeting": "^0.44.1",
2121
"@material/ripple": "^0.44.1",
2222
"@material/rtl": "^0.42.0",
23-
"@material/selection-control": "^0.44.1",
2423
"@material/theme": "^0.43.0"
2524
}
2625
}

packages/mdc-form-field/component.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,22 +22,26 @@
2222
*/
2323

2424
import {MDCComponent} from '@material/base/component';
25-
import {MDCSelectionControl} from '@material/selection-control/types';
25+
import {MDCRipple} from '@material/ripple/component';
2626
import {MDCFormFieldAdapter} from './adapter';
2727
import {MDCFormFieldFoundation} from './foundation';
2828

29+
export interface MDCFormFieldInput {
30+
readonly ripple: MDCRipple | undefined;
31+
}
32+
2933
export class MDCFormField extends MDCComponent<MDCFormFieldFoundation> {
3034
static attachTo(root: HTMLElement) {
3135
return new MDCFormField(root);
3236
}
3337

34-
private input_?: MDCSelectionControl;
38+
private input_?: MDCFormFieldInput;
3539

36-
set input(input: MDCSelectionControl | undefined) {
40+
set input(input: MDCFormFieldInput | undefined) {
3741
this.input_ = input;
3842
}
3943

40-
get input(): MDCSelectionControl | undefined {
44+
get input(): MDCFormFieldInput | undefined {
4145
return this.input_;
4246
}
4347

packages/mdc-form-field/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
},
1616
"dependencies": {
1717
"@material/base": "^0.41.0",
18+
"@material/ripple": "^0.44.0",
1819
"@material/rtl": "^0.42.0",
19-
"@material/selection-control": "^0.44.1",
2020
"@material/theme": "^0.43.0",
2121
"@material/typography": "^0.44.1"
2222
}

packages/mdc-radio/component.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,10 @@
2323

2424
import {MDCComponent} from '@material/base/component';
2525
import {MDCRipple, MDCRippleAdapter, MDCRippleCapableSurface, MDCRippleFoundation} from '@material/ripple/index';
26-
import {MDCSelectionControl} from '@material/selection-control/index';
2726
import {MDCRadioAdapter} from './adapter';
2827
import {MDCRadioFoundation} from './foundation';
2928

30-
export class MDCRadio extends MDCComponent<MDCRadioFoundation> implements MDCRippleCapableSurface, MDCSelectionControl {
29+
export class MDCRadio extends MDCComponent<MDCRadioFoundation> implements MDCRippleCapableSurface {
3130
static attachTo(root: Element) {
3231
return new MDCRadio(root);
3332
}

packages/mdc-radio/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"@material/base": "^0.41.0",
1919
"@material/feature-targeting": "^0.44.1",
2020
"@material/ripple": "^0.44.1",
21-
"@material/selection-control": "^0.44.1",
2221
"@material/theme": "^0.43.0"
2322
}
2423
}

packages/mdc-selection-control/index.ts

Lines changed: 0 additions & 24 deletions
This file was deleted.

packages/mdc-selection-control/package.json

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/mdc-selection-control/types.ts

Lines changed: 0 additions & 35 deletions
This file was deleted.

packages/mdc-switch/component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import {MDCComponent} from '@material/base/component';
2525
import {EventType} from '@material/base/types';
2626
import {ponyfill} from '@material/dom/index';
2727
import {MDCRipple, MDCRippleAdapter, MDCRippleCapableSurface, MDCRippleFoundation} from '@material/ripple/index';
28-
import {MDCSelectionControl} from '@material/selection-control/index';
2928
import {MDCSwitchAdapter} from './adapter';
3029
import {MDCSwitchFoundation} from './foundation';
3130

@@ -34,8 +33,7 @@ import {MDCSwitchFoundation} from './foundation';
3433
*
3534
* https://material.io/design/components/selection-controls.html#switches
3635
*/
37-
export class MDCSwitch extends MDCComponent<MDCSwitchFoundation>
38-
implements MDCSelectionControl, MDCRippleCapableSurface {
36+
export class MDCSwitch extends MDCComponent<MDCSwitchFoundation> implements MDCRippleCapableSurface {
3937
static attachTo(root: HTMLElement) {
4038
return new MDCSwitch(root);
4139
}

packages/mdc-switch/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"@material/feature-targeting": "^0.44.1",
2222
"@material/ripple": "^0.44.1",
2323
"@material/rtl": "^0.42.0",
24-
"@material/selection-control": "^0.44.1",
2524
"@material/theme": "^0.43.0"
2625
},
2726
"publishConfig": {

scripts/check-pkg-for-release.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ const CSS_WHITELIST = [
7171
'dom',
7272
'feature-targeting',
7373
'rtl',
74-
'selection-control',
7574
'shape',
7675
];
7776

@@ -85,7 +84,6 @@ const NOT_AUTOINIT = [
8584
'base',
8685
'dom',
8786
'icon-toggle',
88-
'selection-control',
8987
'tab', // Only makes sense in context of tab-bar
9088
'tab-indicator', // Only makes sense in context of tab-bar
9189
'tab-scroller', // Only makes sense in context of tab-bar

scripts/webpack/js-bundle-factory.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ class JsBundleFactory {
173173
radio: getAbsolutePath('/packages/mdc-radio/index.ts'),
174174
ripple: getAbsolutePath('/packages/mdc-ripple/index.ts'),
175175
select: getAbsolutePath('/packages/mdc-select/index.ts'),
176-
selectionControl: getAbsolutePath('/packages/mdc-selection-control/index.ts'),
177176
slider: getAbsolutePath('/packages/mdc-slider/index.ts'),
178177
snackbar: getAbsolutePath('/packages/mdc-snackbar/index.ts'),
179178
switch: getAbsolutePath('/packages/mdc-switch/index.ts'),

0 commit comments

Comments
 (0)