Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability in Content Pipeline extension #51

Open
red-asparagus opened this issue Sep 17, 2018 · 3 comments
Open

Usability in Content Pipeline extension #51

red-asparagus opened this issue Sep 17, 2018 · 3 comments

Comments

@red-asparagus
Copy link

red-asparagus commented Sep 17, 2018

TiledSharp cant be used in Content Pipeline Extension Project as it is don't have empty constructor.

My proposition: add Empty Constructor and make new method that accept filename and works like TmxMap(string filename) constructor.

@marshallward
Copy link
Owner

Thanks for pointing this out, I have not used the Content Pipeline (from XNA/MonoGame, I assume).

Would multiple constructors work here, one with filename and one without? This would preserve the current API. We can resolve the issues around undefined fields separately.

@red-asparagus
Copy link
Author

No problems with non-empty constructor, but method Load() I think need to be public.

@red-asparagus
Copy link
Author

Created pull request

#52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants