Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert fixing broken wp-embed.min.js #5

Open
szepeviktor opened this issue Nov 3, 2016 · 8 comments
Open

Revert fixing broken wp-embed.min.js #5

szepeviktor opened this issue Nov 3, 2016 · 8 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Nov 3, 2016 •
edited
Loading

When wp-embed.min.js gets fixed 4848800 should be reverted.

To track:
https://github.com/WordPress/WordPress/commits/master/wp-includes/js/wp-embed.js
@szepeviktor
Copy link
Contributor Author

@markoheijnen Is there a bug report for this?

https://core.trac.wordpress.org/search?q=wp-embed

@markoheijnen
Copy link
Owner

I believe it's the grunt uglify plugin that causes it.

@szepeviktor
Copy link
Contributor Author

UglifyJS2 has very high code quality.

@szepeviktor
Copy link
Contributor Author

Let's see https://core.trac.wordpress.org/ticket/38646

@markoheijnen
Copy link
Owner

Thanks for creating the ticket

@szepeviktor
Copy link
Contributor Author

mishoo/UglifyJS#1447 (comment)

@szepeviktor
Copy link
Contributor Author

We've got an "answer" mishoo/UglifyJS#1447 (comment)

@szepeviktor
Copy link
Contributor Author

@markoheijnen The core ticket is closed. So we may move on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markoheijnen @szepeviktor