Skip to content

Commit a02b2a2

Browse files
shemmingerdavid-marchand
authored andcommitted
net/qede: use a better random generator for RSS key
The function of rand() is a weak random number generator. Use the DPDK rte_rand() instead. Note: this doesn't matter for real security, since most drivers use a fixed RSS default key. Signed-off-by: Stephen Hemminger <[email protected]> Reviewed-by: Tyler Retzlaff <[email protected]>
1 parent f4495ba commit a02b2a2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/qede/qede_ethdev.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include "qede_ethdev.h"
88
#include <rte_string_fns.h>
99
#include <rte_alarm.h>
10+
#include <rte_random.h>
1011
#include <rte_kvargs.h>
1112

1213
static const struct qed_eth_ops *qed_ops;
@@ -1040,9 +1041,8 @@ static void qede_prandom_bytes(uint32_t *buff)
10401041
{
10411042
uint8_t i;
10421043

1043-
srand((unsigned int)time(NULL));
10441044
for (i = 0; i < ECORE_RSS_KEY_SIZE; i++)
1045-
buff[i] = rand();
1045+
buff[i] = rte_rand();
10461046
}
10471047

10481048
int qede_config_rss(struct rte_eth_dev *eth_dev)

0 commit comments

Comments
 (0)