Skip to content

Commit 63a98ff

Browse files
shemmingertmonjalo
authored andcommitted
gro: use mbuf API for offset addition
Replace explicit packet offset computations with rte_pktmbuf_mtod_offset(). Signed-off-by: Stephen Hemminger <[email protected]> Acked-by: Chengwen Feng <[email protected]>
1 parent 0c4a63c commit 63a98ff

File tree

6 files changed

+12
-12
lines changed

6 files changed

+12
-12
lines changed

lib/gro/gro_tcp.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ check_seq_option(struct gro_tcp_item *item,
150150
struct rte_tcp_hdr *tcph_orig;
151151
uint16_t len, tcp_hl_orig;
152152

153-
iph_orig = (char *)(rte_pktmbuf_mtod(pkt_orig, char *) +
154-
l2_offset + pkt_orig->l2_len);
153+
iph_orig = rte_pktmbuf_mtod_offset(pkt_orig, char *,
154+
l2_offset + pkt_orig->l2_len);
155155
tcph_orig = (struct rte_tcp_hdr *)(iph_orig + pkt_orig->l3_len);
156156
tcp_hl_orig = pkt_orig->l4_len;
157157

lib/gro/gro_tcp4.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ update_header(struct gro_tcp_item *item)
223223
struct rte_ipv4_hdr *ipv4_hdr;
224224
struct rte_mbuf *pkt = item->firstseg;
225225

226-
ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +
227-
pkt->l2_len);
226+
ipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,
227+
pkt->l2_len);
228228
ipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len -
229229
pkt->l2_len);
230230
}

lib/gro/gro_tcp6.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ update_header(struct gro_tcp_item *item)
118118
struct rte_ipv6_hdr *ipv6_hdr;
119119
struct rte_mbuf *pkt = item->firstseg;
120120

121-
ipv6_hdr = (struct rte_ipv6_hdr *)(rte_pktmbuf_mtod(pkt, char *) +
122-
pkt->l2_len);
121+
ipv6_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv6_hdr *,
122+
pkt->l2_len);
123123
ipv6_hdr->payload_len = rte_cpu_to_be_16(pkt->pkt_len -
124124
pkt->l2_len - pkt->l3_len);
125125
}

lib/gro/gro_udp4.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,8 @@ update_header(struct gro_udp4_item *item)
179179
struct rte_mbuf *pkt = item->firstseg;
180180
uint16_t frag_offset;
181181

182-
ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +
183-
pkt->l2_len);
182+
ipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,
183+
pkt->l2_len);
184184
ipv4_hdr->total_length = rte_cpu_to_be_16(pkt->pkt_len -
185185
pkt->l2_len);
186186

lib/gro/gro_vxlan_tcp4.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,8 @@ update_vxlan_header(struct gro_vxlan_tcp4_item *item)
263263

264264
/* Update the outer IPv4 header. */
265265
len = pkt->pkt_len - pkt->outer_l2_len;
266-
ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +
267-
pkt->outer_l2_len);
266+
ipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,
267+
pkt->outer_l2_len);
268268
ipv4_hdr->total_length = rte_cpu_to_be_16(len);
269269

270270
/* Update the outer UDP header. */

lib/gro/gro_vxlan_udp4.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -259,8 +259,8 @@ update_vxlan_header(struct gro_vxlan_udp4_item *item)
259259

260260
/* Update the outer IPv4 header. */
261261
len = pkt->pkt_len - pkt->outer_l2_len;
262-
ipv4_hdr = (struct rte_ipv4_hdr *)(rte_pktmbuf_mtod(pkt, char *) +
263-
pkt->outer_l2_len);
262+
ipv4_hdr = rte_pktmbuf_mtod_offset(pkt, struct rte_ipv4_hdr *,
263+
pkt->outer_l2_len);
264264
ipv4_hdr->total_length = rte_cpu_to_be_16(len);
265265

266266
/* Update the outer UDP header. */

0 commit comments

Comments
 (0)