Bug 1872005 [wpt PR 43800] - Implement :state(foo) alongside :--foo, a=testonly

marco-c · marco-c · commit fc504f798350 · 2024-02-08T15:15:02.000Z
Automatic update from web-platform-tests Implement :state(foo) alongside :--foo This patch implements :state(foo) alongsite :--foo so that we can have both supported on stable at the same time and then deprecate/remove :--foo. This patch does not enable :state(foo) by default. I will do that after implementing deprecation for :--foo. Due to pushback from webkit, the syntax for this feature was discussed again in the CSSWG, and a resolution was made to go back from :--foo to :state(foo): w3c/csswg-drafts#4805 (comment) This was discussed in an I2S where we decided to only deprecate :--foo if WebKit ships :--foo, which has now happened. https://groups.google.com/a/chromium.org/g/blink-dev/c/JvpHoUfhJYE Fixed: 1508033 Bug: 1514397 Change-Id: I497fd5acc05ba033e8e72c429568099c89d5d639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5153145 Reviewed-by: Mason Freed <masonfchromium.org> Auto-Submit: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1254746} -- wpt-commits: 9fd7672ceccd3cfec2ecc89647963acf5ae3c372 wpt-pr: 43800 UltraBlame original commit: 9ba5dbb2106671ac2cb5dff896340046d96e0e1c
diff --git a/testing/web-platform/tests/custom-elements/state/tentative/ElementInternals-states.html b/testing/web-platform/tests/custom-elements/state/tentative/ElementInternals-states.html
@@ -27,6 +27,8 @@
 test(() => {
   let i = (new TestElement()).internals;
   assert_throws_js(TypeError, () => { i.states.supports('foo'); });
+  i.states.add(''); // should not throw.
+  i.states.add('--a\tb'); // should not throw.
 }, 'CustomStateSet behavior of ElementInternals.states: Exceptions');
 
 test(() => {
diff --git a/testing/web-platform/tests/custom-elements/state/tentative/state-pseudo-class.html b/testing/web-platform/tests/custom-elements/state/tentative/state-pseudo-class.html
@@ -11,7 +11,7 @@
 #state-and-part:state(outerFoo)::part(inner) {
   opacity: 0.25;
 }
-:state(--\)escaped\ state) {}
+:state( \(escaped\ state  ) {}
 </style>
 <body>
 <script>
@@ -60,22 +60,29 @@
   document.querySelector(':state(--16px)');
 }, ':state() parsing passes');
 
+test(() => {
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state'); });
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state('); });
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state()'); });
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state(=)'); });
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state(name=value)'); });
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state( foo bar)'); });
+  assert_throws_dom('SyntaxError', () => { document.querySelector(':state(16px)'); });
+}, ':state() parsing failures');
+
 test(() => {
   assert_throws_dom('SyntaxError', () => { document.querySelector(':--('); });
   assert_throws_dom('SyntaxError', () => { document.querySelector(':--()'); });
-  assert_throws_dom('SyntaxError', () => { document.querySelector(':state()'); });
   assert_throws_dom('SyntaxError', () => { document.querySelector(':--)'); });
   assert_throws_dom('SyntaxError', () => { document.querySelector(':--='); });
   assert_throws_dom('SyntaxError', () => { document.querySelector(':--name=value'); });
-  assert_throws_dom('SyntaxError', () => { document.querySelector(':state(--name=value'); });
-  assert_throws_dom('SyntaxError', () => { document.querySelector(':state(--name=value)'); });
-}, ':state() parsing failures');
+}, 'deprecated :--state parsing failures');
 
 test(() => {
   assert_equals(document.styleSheets[0].cssRules[1].cssText,
       '#state-and-part::part(inner):state(innerFoo) { opacity: 0.5; }');
   assert_equals(document.styleSheets[0].cssRules[3].selectorText,
-      ':state(--\\)escaped\\ state)');
+      ':state(\\(escaped\\ state)');
 }, ':state(foo) serialization');
 
 test(() => {
@@ -112,13 +119,13 @@
   let inner = outer.innerElement;
   let innerStates = inner.i.states;
 
-  innerStates.add(':state(innerFoo)');
+  innerStates.add('innerFoo');
   assert_equals(getComputedStyle(inner).opacity, '0.5',
-      '::part() followed by :state(innerFoo)');
+      '::part() followed by :state()');
   innerStates.delete('innerFoo');
   innerStates.add('innerfoo');
   assert_equals(getComputedStyle(inner).opacity, '0',
-      ':state(foo) matching should be case-sensitive');
+      ':state() matching should be case-sensitive');
   innerStates.delete('innerfoo');
 
   outer.i.states.add('outerFoo');
