Avoid redundant bindings/states based on Metal profiler feedback. #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate unused blit encoders.
TimSylvester
requested review from
louwers,
stefankarschti,
alexcristici,
mwilsnd and
sjg-wdw
sjg-wdw
approved these changes
Jan 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2006 +/- ##
==========================================
+ Coverage 85.70% 85.72% +0.01%
==========================================
Files 569 569
Lines 28053 28053
==========================================
+ Hits 24044 24048 +4
+ Misses 4009 4005 -4 ☔ View full report in Codecov by Sentry. |
Bloaty Results 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2006-compared-to-main.txtCompared to d387090 (legacy) Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2006-compared-to-legacy.txt |
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2006-compared-to-main.txt |
stefankarschti
approved these changes
Jan 9, 2024
alexcristici
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses some of the issues reported by the Metal capture/profile tools, specifically redundant vertex bindings, depth/stencil and sampler state descriptors, and blit encoders.
A large number of issues are still reported, mostly around binding the same "bytes" (where the data is placed directly in the encoder as opposed to a Metal buffer reference). This is to be expected, as similar drawables will bind the same values for some arguments to the same indexes.
The implication that these bindings can be elided does not seem to be true, however. Checking for buffer content equality in addition to buffer instance equality does resolve most of the reported issues, but does not render correctly. This appears to be an inconsistency between the debug tool and the actual encoder behavior. It's possible that it was just a bug, however, and it would be possible to elide many more of the
set[Fragment|Vertex]Bytescalls, at the cost ofmemcmpcalls.While this eliminates some hundreds of
objc_msgSendcalls per frame and improves the times reported by the Time Profiler tool, unfortunately it didn't produce any significant difference in measured encoding or rendering times from the benchmark app.