-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBO by index instead of map #1980
UBO by index instead of map #1980
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…cristici/maplibre-native into ubo-by-index-instead-of-map
for more information, see https://pre-commit.ci
Bloaty Results 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1980-compared-to-main.txtCompared to d387090 (legacy)
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-1980-compared-to-legacy.txt |
Bloaty Results (iOS) 🐋Compared to main
Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-1980-compared-to-main.txt |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…cristici/maplibre-native into ubo-by-index-instead-of-map
for more information, see https://pre-commit.ci
…cristici/maplibre-native into ubo-by-index-instead-of-map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Guess I need to dust off that shader code generation PR when I have a chance and really update it for this.
I replaced
StringIdentity idBackgroundDrawableUBOName
withUBOs ids are in the same order in UniformBlocks as in UniformBuffers, using above enum ordering.
In this way we match the uniform buffer for the right uniform block.