From 072abf02f58b923d74736277c1e15af4de8c0162 Mon Sep 17 00:00:00 2001 From: Richard Barnes Date: Wed, 14 Feb 2024 16:16:41 -0800 Subject: [PATCH] Remove unused variables in mapillary/opensfm/opensfm/src/geometry/pose.h Summary: LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance. This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: palmje Differential Revision: D53779585 fbshipit-source-id: d651d6b4cf4dbc777f924f936e9325005c80d2ba --- opensfm/src/geometry/pose.h | 1 - 1 file changed, 1 deletion(-) diff --git a/opensfm/src/geometry/pose.h b/opensfm/src/geometry/pose.h index c015e7b7f..736563b3d 100644 --- a/opensfm/src/geometry/pose.h +++ b/opensfm/src/geometry/pose.h @@ -17,7 +17,6 @@ class Pose { virtual ~Pose() = default; Pose(const Vec3d& R, const Vec3d& t = Vec3d::Zero()) { - Mat4d T_cw = Mat4d::Identity(); SetFromWorldToCamera(R, t); } Pose(const Mat3d& R, const Vec3d& t = Vec3d::Zero()) {