Lua: fix nil reference in columns

Author: manups4e

ScaleformUI_Lua/src/Menus/PauseMenus/LobbyMenu/Columns/MissionListColumn.lua

@@ -98,7 +98,6 @@ end
 ---Adds a new player to the column.
 ---@param item MissionItem
 function MissionListColumn:AddMissionItem(item)
-    local pSubT = self.Parent()
     item.ParentColumn = self
     item.Handle = #self.Items + 1
     self.Items[item.Handle] = item
@@ -118,12 +117,14 @@ function MissionListColumn:AddMissionItem(item)
 
             self.Pagination:MaxItem(self.Pagination:CurrentPageEndIndex())
             self:_itemCreation(self.Pagination:CurrentPage(), #self.Items, false)
+            local pSubT = self.Parent()
             if pSubT == "PauseMenu" and self.ParentTab.Visible then
                 if self.ParentTab.listCol[self.ParentTab:Focus()] == self then
                     self:CurrentSelection(sel)
                 end
             end
         end
+        local pSubT = self.Parent()
         if pSubT == "LobbyMenu" then
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_MISSIONS_SELECTION", self.Pagination:ScaleformIndex()) --[[@as number]]
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_MISSIONS_QTTY", self:CurrentSelection(), #self.Items) --[[@as number]]

ScaleformUI_Lua/src/Menus/PauseMenus/LobbyMenu/Columns/PlayerListColumn.lua

@@ -120,7 +120,6 @@ end
 ---Adds a new player to the column.
 ---@param item FriendItem
 function PlayerListColumn:AddPlayer(item)
-    local pSubT = self.Parent()
     item.ParentColumn = self
     item.Handle = #self.Items + 1
     self.Items[item.Handle] = item
@@ -140,12 +139,14 @@ function PlayerListColumn:AddPlayer(item)
 
             self.Pagination:MaxItem(self.Pagination:CurrentPageEndIndex())
             self:_itemCreation(self.Pagination:CurrentPage(), #self.Items, false)
+            local pSubT = self.Parent()
             if pSubT == "PauseMenu" and self.ParentTab.Visible then
                 if self.ParentTab.listCol[self.ParentTab:Focus()] == self then
                     self:CurrentSelection(sel)
                 end
             end
         end
+        local pSubT = self.Parent()
         if pSubT == "LobbyMenu" then
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_PLAYERS_SELECTION", self.Pagination:ScaleformIndex()) --[[@as number]]
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_PLAYERS_QTTY", self:CurrentSelection(), #self.Items) --[[@as number]]

ScaleformUI_Lua/src/Menus/PauseMenus/LobbyMenu/Columns/SettingsListColumn.lua

@@ -92,7 +92,6 @@ end
 ---Add a new item to the column.
 ---@param item UIMenuItem|UIMenuListItem|UIMenuCheckboxItem|UIMenuSliderItem|UIMenuProgressItem
 function SettingsListColumn:AddSettings(item)
-    local pSubT = self.Parent()
     local a, b = item()
     if b == "UIMenuItem" then
         item.ParentColumn = self
@@ -116,12 +115,14 @@ function SettingsListColumn:AddSettings(item)
 
             self.Pagination:MaxItem(self.Pagination:CurrentPageEndIndex())
             self:_itemCreation(self.Pagination:CurrentPage(), #self.Items, false)
+            local pSubT = self.Parent()
             if pSubT == "PauseMenu" and self.ParentTab.Visible then
                 if self.ParentTab.listCol[self.ParentTab:Focus()] == self then
                     self:CurrentSelection(sel)
                 end
             end
         end
+        local pSubT = self.Parent()
         if pSubT == "LobbyMenu" then
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_SETTINGS_SELECTION", self.Pagination:ScaleformIndex()) --[[@as number]]
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_SETTINGS_QTTY", self:CurrentSelection(), #self.Items) --[[@as number]]

ScaleformUI_Lua/src/Menus/PauseMenus/LobbyMenu/Columns/StoreListColumn.lua

@@ -92,7 +92,6 @@ end
 ---Add a new item to the column.
 ---@param item StoreItem
 function StoreListColumn:AddStoreItem(item)
-    local pSubT = self.Parent()
     item.ParentColumn = self
     item.Handle = #self.Items + 1
     self.Items[#self.Items + 1] = item
@@ -112,12 +111,14 @@ function StoreListColumn:AddStoreItem(item)
 
             self.Pagination:MaxItem(self.Pagination:CurrentPageEndIndex())
             self:_itemCreation(self.Pagination:CurrentPage(), #self.Items, false)
+            local pSubT = self.Parent()
             if pSubT == "PauseMenu" and self.ParentTab.Visible then
                 if self.ParentTab.listCol[self.ParentTab:Focus()] == self then
                     self:CurrentSelection(sel)
                 end
             end
         end
+        local pSubT = self.Parent()
         if pSubT == "LobbyMenu" then
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_STORE_SELECTION", self.Pagination:ScaleformIndex()) --[[@as number]]
             ScaleformUI.Scaleforms._pauseMenu._lobby:CallFunction("SET_STORE_QTTY", self:CurrentSelection(), #self.Items) --[[@as number]]