GitWeb: use url_get() to retrieve data with basic auth

dregad · dregad · commit 710d32f2ac8a · 2017-05-28T15:08:02.000+02:00
Fixes #218
diff --git a/SourceGitweb/SourceGitweb.php b/SourceGitweb/SourceGitweb.php
@@ -34,11 +34,9 @@ public function register() {
 	public function url_get_auth( $p_url, $p_user, $p_pass ) {
 		if( strlen( $p_user ) > 0 && strlen( $p_pass ) > 0 ) {
 			$t_url_parts = preg_split("/:\\/\\//", $p_url );
-			$t_url_with_credentials = $t_url_parts[0] . "://" . $p_user . ":" . $p_pass . "@" .$t_url_parts[1];
-			return file_get_contents( $t_url_with_credentials );
-		} else {
-			return url_get( $p_url );
+			$p_url = $t_url_parts[0] . "://" . $p_user . ":" . $p_pass . "@" .$t_url_parts[1];
 		}
+		return url_get( $p_url );
 	}
 
 	public function show_type() {

Original file line number	Diff line number	Diff line change
`@@ -34,11 +34,9 @@ public function register() {`
`34`	`34`	`public function url_get_auth( $p_url, $p_user, $p_pass ) {`
`35`	`35`	`if( strlen( $p_user ) > 0 && strlen( $p_pass ) > 0 ) {`
`36`	`36`	`$t_url_parts = preg_split("/:\\/\\//", $p_url );`
`37`		`- $t_url_with_credentials = $t_url_parts[0] . "://" . $p_user . ":" . $p_pass . "@" .$t_url_parts[1];`
`38`		`- return file_get_contents( $t_url_with_credentials );`
`39`		`- } else {`
`40`		`- return url_get( $p_url );`
	`37`	`+ $p_url = $t_url_parts[0] . "://" . $p_user . ":" . $p_pass . "@" .$t_url_parts[1];`
`41`	`38`	`}`
	`39`	`+ return url_get( $p_url );`
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`public function show_type() {`