Add address length check to Keypair

Author: bartekn

src/keypair.js

@@ -38,6 +38,9 @@ export class Keypair {
 
   static fromAddress(address) {
     let publicKey = strkey.decodeCheck("accountId", address);
+    if (publicKey.length !== 32) {
+      throw new Error('Invalid Stellar address');
+    }
     return new this({publicKey});
   }
 

test/unit/keypair_test.js

@@ -106,7 +106,13 @@ describe('Keypair.fromAddress', function() {
     expect(() => StellarBase.Keypair.fromAddress("hel0")).to.throw()
     expect(() => StellarBase.Keypair.fromAddress("masterpassphrasemasterpassphrase")).to.throw()
     expect(() => StellarBase.Keypair.fromAddress("sfyjodTxbwLtRToZvi6yQ1KnpZriwTJ7n6nrASFR6goRviCU3Ff")).to.throw()
+  });
 
+  it("throws an error if the address isn't 32 bytes", function() {
+    expect(() => StellarBase.Keypair.fromAddress("masterpassphrasemasterpassphrase")).to.throw()
+    expect(() => StellarBase.Keypair.fromAddress("masterpassphrasemasterpassphrase")).to.throw()
+    expect(() => StellarBase.Keypair.fromAddress(null)).to.throw()
+    expect(() => StellarBase.Keypair.fromAddress()).to.throw()
   });
 
 });