Skip to content

Commit b7dcae4

Browse files
authored
KAFKA-16373: KIP-1028: Modfiying download url for kafka dockerfile (apache#16281)
This PR modifies the download url from https://downloads.apache.org/kafka/ to https://archive.apache.org/dist/kafka/ as the former is not permanent. Reviewers: Manikumar Reddy <[email protected]>, Vedarth Sharma <[email protected]>
1 parent f746d67 commit b7dcae4

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

docker/docker_official_image_build_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def build_docker_official_image(image, tag, kafka_version, image_type):
7676
parser.add_argument("--test", "-t", action="store_true", dest="test_only",
7777
default=False, help="Only run the tests, don't build the image")
7878
args = parser.parse_args()
79-
kafka_url = f"https://downloads.apache.org/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz"
79+
kafka_url = f"https://archive.apache.org/dist/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz"
8080
if args.build_only or not (args.build_only or args.test_only):
8181
if args.kafka_version:
8282
build_docker_official_image(args.image, args.tag, args.kafka_version, args.image_type)

docker/docker_official_images/3.7.0/jvm/Dockerfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ FROM eclipse-temurin:21-jre-alpine AS build-jsa
2020

2121
USER root
2222

23-
# Get Kafka from https://downloads.apache.org/kafka, url passed as env var, for version 3.7.0
24-
ENV kafka_url https://downloads.apache.org/kafka/3.7.0/kafka_2.13-3.7.0.tgz
23+
# Get Kafka from https://archive.apache.org/dist/kafka, url passed as env var, for version 3.7.0
24+
ENV kafka_url https://archive.apache.org/dist/kafka/3.7.0/kafka_2.13-3.7.0.tgz
2525

2626
COPY jsa_launch /etc/kafka/docker/jsa_launch
2727

@@ -48,9 +48,9 @@ EXPOSE 9092
4848

4949
USER root
5050

51-
# Get Kafka from https://downloads.apache.org/kafka, url passed as env var, for version 3.7.0
52-
ENV kafka_url https://downloads.apache.org/kafka/3.7.0/kafka_2.13-3.7.0.tgz
53-
ENV build_date 2024-06-10
51+
# Get Kafka from https://archive.apache.org/dist/kafka, url passed as env var, for version 3.7.0
52+
ENV kafka_url https://archive.apache.org/dist/kafka/3.7.0/kafka_2.13-3.7.0.tgz
53+
ENV build_date 2024-06-11
5454

5555

5656
LABEL org.label-schema.name="kafka" \

docker/prepare_docker_official_image_source.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def remove_args_and_hardcode_values(file_path, kafka_version, kafka_url):
4646
filedata = filedata.replace(
4747
"ARG build_date", f"ENV build_date {str(date.today())}")
4848
original_comment = re.compile(r"# Get kafka from https://archive.apache.org/dist/kafka and pass the url through build arguments")
49-
updated_comment = f"# Get Kafka from https://downloads.apache.org/kafka, url passed as env var, for version {kafka_version}"
49+
updated_comment = f"# Get Kafka from https://archive.apache.org/dist/kafka, url passed as env var, for version {kafka_version}"
5050
filedata = original_comment.sub(updated_comment, filedata)
5151
with open(file_path, 'w') as file:
5252
file.write(filedata)
@@ -59,7 +59,7 @@ def remove_args_and_hardcode_values(file_path, kafka_version, kafka_url):
5959
parser.add_argument("--kafka-version", "-v", dest="kafka_version",
6060
help="Kafka version for which the source for docker official image is to be built")
6161
args = parser.parse_args()
62-
kafka_url = f"https://downloads.apache.org/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz"
62+
kafka_url = f"https://archive.apache.org/dist/kafka/{args.kafka_version}/kafka_2.13-{args.kafka_version}.tgz"
6363
current_dir = os.path.dirname(os.path.realpath(__file__))
6464
new_dir = os.path.join(
6565
current_dir, f'docker_official_images', args.kafka_version)

0 commit comments

Comments
 (0)